Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0: Roadmap #200

Closed
25 tasks done
denysdovhan opened this issue Aug 22, 2017 · 15 comments
Closed
25 tasks done

3.0: Roadmap #200

denysdovhan opened this issue Aug 22, 2017 · 15 comments
Assignees
Labels
breaking ‼️ BREAKING CHANGES ‼️ All breaking changes go under major release.
Milestone

Comments

@denysdovhan
Copy link
Member

denysdovhan commented Aug 22, 2017

A checklist and discussion about v3.0 (#148) release and new features.

Roadmap


  • (Optional) Add ability to render prompt with agnoster-like segments
  • (Optional) Add tests for basic functionality
  • (Optional) Speed up with async rendering
@denysdovhan denysdovhan added breaking ‼️ BREAKING CHANGES ‼️ All breaking changes go under major release. has-pr labels Aug 22, 2017
@denysdovhan denysdovhan added this to the v3.0 milestone Aug 22, 2017
@denysdovhan
Copy link
Member Author

@sfarzy I would like to use Conventional Commits. Very useful for generating changelogs. What do you think?

@denysdovhan
Copy link
Member Author

@sfarzy however, I don't want to introduce new dependency like standard-version. Also, I don't like limitations with this approach.

@salmanulfarzy
Copy link
Member

Very useful for generating changelogs

Take a look at skywinder/github-changelog-generator, It's does the job well.

@nfischer
Copy link
Contributor

At ShellJS we created https://github.com/shelljs/changelog. This wraps around skywinder's project.

@salmanulfarzy
Copy link
Member

Slow git status checking

Currently we're using git status --porcelain -b in git section. But it was noted slow in multiple issues. Is there any better way in doing this ?

@denysdovhan
Copy link
Member Author

@salmanulfarzy zsh can provide vsc information out of the box, but it wouldn't be as reach as our implementation.

@sei40kr
Copy link

sei40kr commented Oct 18, 2017

@denysdovhan

  • (Optional) Speed up with async rendering
    Are you implementing this now?
    I really want this feature, so I would like to implement this if you're not working on now.

@denysdovhan
Copy link
Member Author

@sei40kr I was playing in a playground with zsh-async. However, I don't have enough time to dive deeper and implement this right now. Would be great if you help!

Please, open another PR to the 3.0 branch. Async API has to be discussed.

@denysdovhan
Copy link
Member Author

@sei40kr any updates?

@belak
Copy link
Contributor

belak commented Dec 11, 2017

What's the status on this?

@denysdovhan
Copy link
Member Author

@belak currently I'm busy at work and don't have enough time to finish this release. Hope I'll have more time soon.

3.0 features are settled. It only needs to implement spaceship_upgrade/spaceship_uninstall, resolve some conflicts, fix some styling issues and update docs.

You can support my efforts by contributing or donations. Thanks for understanding!

@belak
Copy link
Contributor

belak commented Dec 11, 2017

Not a problem. Thanks for the update! I totally understand being really busy on other stuff.

Since I don't think we need upgrade/uninstall for prezto, I'll add this branch as a theme in our contrib repo and follow this for when there's an official release.

@denysdovhan
Copy link
Member Author

denysdovhan commented Jan 13, 2018

Breaking changes

  • SPACESHIP_PROMPT_SYMBOL has been removed. Use SPACESHIP_CHAR_SYMBOL instead.
  • SPACESHIP_BATTERY_ALWAYS_SHOW has been removed. Use SPACESHIP_BATTERY_SHOW='always' instead.
  • SPACESHIP_BATTERY_CHARGING_SYMBOL has been replaced by SPACESHIP_BATTERY_SYMBOL_CHARGING.
  • SPACESHIP_BATTERY_DISCHARGING_SYMBOL has been replaced by SPACESHIP_BATTERY_SYMBOL_DISCHARGING.
  • SPACESHIP_BATTERY_FULL_SYMBOL has been replaced by SPACESHIP_BATTERY_SYMBOL_FULL.
  • SPACESHIP_HOST_SHOW now accepts value 'always'.
  • SPACESHIP_USER_SHOW now accepts value 'always'.
  • SPACESHIP_HOST_COLOR equals 'blue' instead of 'green'.
  • SPACESHIP_HOST_COLOR_SSH is a new option.
  • SPACESHIP_PROMPT_ORDER has been changed.
  • SPACESHIP_BATTERY_ALWAYS_SHOW has been removed. Use SPACESHIP_BATTERY_SHOW='always' instead.
  • SPACESHIP_PROMPT_FIRST_PREFIX_SHOW is a new option.
  • SPACESHIP_DIR_TRUNC_REPO is a new option.

@denysdovhan
Copy link
Member Author

denysdovhan commented Jan 17, 2018

#313 is ready to merge and waiting for approvement.

The work on #148 is finished and it's ready to merge after approvement.

@denysdovhan
Copy link
Member Author

Published as v3.0.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking ‼️ BREAKING CHANGES ‼️ All breaking changes go under major release.
Development

No branches or pull requests

5 participants