Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java / Gradle / Maven sections #265

Closed
wants to merge 3 commits into from
Closed

Java / Gradle / Maven sections #265

wants to merge 3 commits into from

Conversation

bric3
Copy link
Contributor

@bric3 bric3 commented Nov 13, 2017 •
edited

Targets 3.0

This fixes #138 for spaceship 3.0. I needed them at some point in v3.0 so I developed them without waiting for #139 to be completed.

Also I added maven and gradle support. I am not a fan of the speed of gradle or maven at this time though ; I'm not sure on how to improve this in a reliable way though.

Also I didn't find great icons for gradle and maven, so used respectively ⬡ and 𝑚. Gradle uses an elephant now, but it kinda collides with PHP, and ⬡ looks like their previous logo.

@bric3 bric3 mentioned this pull request Jan 8, 2018
Closed
@denysdovhan denysdovhan added new-feature A PR that implement feature (section, specific behavior, etc). frozen Progress is temporarily frozen until resolving the specific issue. labels Jan 11, 2018
@denysdovhan
Copy link
Member

@bric3 we agreed not introduce new feature until #148 gets merged. 3.0 release has frozen list of features. We will continue this conversation after 3.0 release.

@bric3
Copy link
Contributor Author

bric3 commented Jan 12, 2018

Yep no problem I'm just targeting the next code version ;)
I'll edit the PR once 3.0 is in master.

@salmanulfarzy salmanulfarzy removed the frozen Progress is temporarily frozen until resolving the specific issue. label Jan 20, 2018
salmanulfarzy
salmanulfarzy requested changes Jan 21, 2018
View reviewed changes
Copy link
Member

@salmanulfarzy salmanulfarzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bric3 there are some conflicts, Could you please resolve that ?

@bric3
Copy link
Contributor Author

bric3 commented Jan 22, 2018

OK sure

@salmanulfarzy
Copy link
Member

Note we also modified the API

@bric3
Copy link
Contributor Author

bric3 commented Jan 22, 2018

@denysdovhan closed ?

@maximbaz maximbaz mentioned this pull request Jan 22, 2018
Closed
6 tasks
@denysdovhan denysdovhan changed the base branch from 3.0 to master January 22, 2018 16:51
@denysdovhan denysdovhan reopened this Jan 22, 2018
@bric3
Copy link
Contributor Author

bric3 commented Feb 6, 2018

Sorry for the delay. I just rebased.

ellaqezi
ellaqezi reviewed Apr 8, 2018
View reviewed changes
README.md
| `SPACESHIP_GRADLE_SHOW` | `true` | Show current Gradle version or not |
| `SPACESHIP_GRADLE_PREFIX` | `on ` | Prefix before the Gradle section |
| `SPACESHIP_GRADLE_SUFFIX` | `$SPACESHIP_PROMPT_DEFAULT_SUFFIX` | Suffix after the Gradle section |
| `SPACESHIP_GRADLE_SYMBOL` | `⬡` | Character to be shown before Gradle version |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the symbol be 🐘 since the logo has an elephant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellaqezi I original thought the same thing, but the elephant is being used by the php module.

@rverma-nikiai
Copy link

@bric3 when can we merge this? If there are any open issues related to this I am willing to improve the PR.

@bric3
Copy link
Contributor Author

bric3 commented Nov 20, 2018

@rverma-nikiai it was ready i think at some point, but the README diverged again. Otherwise I think this is good. I don't have merge rights.

@mgaouar
Copy link

mgaouar commented Jul 25, 2019

@bric3 do you think you can resolve the conflict so this get merged? Thanks

@arudge arudge mentioned this pull request Jul 26, 2019
Closed
@arudge
Copy link

arudge commented Jul 26, 2019

this got me again today... compiling a jdk8 version application against jdk11 and it not being able to run.
So, I resolved the merge conflicts on this pr here #709.

@Prototik Prototik mentioned this pull request Jul 27, 2019
Merged
@bric3
Copy link
Contributor Author

bric3 commented Jul 31, 2019

I think the work of @arudge is great, and supersedes the one in this PR, let's close this PR and merge #708

@bric3 bric3 closed this Jul 31, 2019
@bric3 bric3 deleted the java-gradle-maven-sections branch July 31, 2019 15:24
@cswanghan
Copy link

is there any updates on this issue? really need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellaqezi ellaqezi ellaqezi left review comments

@salmanulfarzy salmanulfarzy salmanulfarzy requested changes

Assignees

@bric3 bric3

Labels
new-feature A PR that implement feature (section, specific behavior, etc).
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

☕ Java version
8 participants
@bric3 @denysdovhan @salmanulfarzy @rverma-nikiai @mgaouar @arudge @cswanghan @ellaqezi