Java gradle maven sections #709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmanulfarzy
added
the
frozen
ajgassner
reviewed
Dec 6, 2019
| # Check if maven or gradle project | ||
| [[ -f pom.xml || -f build.gradle || -f build.gradle.kts ]] || return | ||
|
|
||
| local java_version=$(java -version 2>&1 | grep '^java version ' | awk -F '"' '{print $2}') |
There was a problem hiding this comment.
to support OpenJDK as well local java_version=$(java -version 2>&1 | grep 'version ' | awk -F '"' '{print $2}') should be used
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve conflicts in this PR #265
If there are docs on how to test locally first, I think that would be a good idea and happy to do that.
I just resolved the readme conflicts in this PR.