Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ocaml section #561

Closed
wants to merge 3 commits into from
Closed

Add ocaml section #561

wants to merge 3 commits into from

Conversation

atongen
Copy link

@atongen atongen commented Nov 17, 2018 •
edited
Loading

Description

Adds ocaml section.

Screenshot

2018-11-21-150429_2880x1800_scrot

Update: After upgrading to ubuntu 18.04 (bionic beaver), prompt now looks like this:

ocaml-spaceship

@salmanulfarzy
Copy link
Member

Few questions about section,

  • Does ocaml version changes so often that it needs to be shown in prompt ?
  • Is there any ocaml version management system ?

CONTRIBUTING.md#section

@salmanulfarzy salmanulfarzy added new-feature A PR that implement feature (section, specific behavior, etc). under-discussion labels Nov 18, 2018
salmanulfarzy
salmanulfarzy reviewed Nov 18, 2018
View reviewed changes
spaceship.zsh Outdated Show resolved Hide resolved
@atongen
Copy link
Author

atongen commented Nov 18, 2018

Many ocaml projects use opam for package management. Opam has a concept of a switch, which is similar to a python virtualenv. Different codebases use different switches. I find it helpful to see the active switch, or ocaml version in the prompt when in an ocaml-related directory.

Runrioter
Runrioter reviewed Nov 19, 2018
View reviewed changes
README.md Outdated Show resolved Hide resolved
Runrioter
Runrioter reviewed Nov 19, 2018
View reviewed changes
docs/Options.md Outdated Show resolved Hide resolved
Runrioter
Runrioter reviewed Nov 19, 2018
View reviewed changes
sections/ocaml.zsh Outdated Show resolved Hide resolved
@Runrioter
Copy link
Member

🐪 dromedary camel => Perl language
🐫 bactrian camel => Ocaml language

Supporting Perl is a welcome PR, too.

@denysdovhan
Copy link
Member

@atongen what about flow, which is written in OCaml. Would this section be helpful for flow users? 🧐

Personally, seems helpful.

@atongen
Copy link
Author

atongen commented Nov 21, 2018

@Runrioter Good catch, thanks! This has been updated.

@atongen
Copy link
Author

atongen commented Nov 21, 2018

@denysdovhan I have not used flow myself, so I don't know. This section would be generally useful for ocaml code, but not js.

@atongen
Copy link
Author

atongen commented Dec 6, 2018

@denysdovhan @salmanulfarzy @Runrioter, any thoughts on this? Thanks!

@XVilka
Copy link

XVilka commented Jul 23, 2019

Are there any updates? It is very useful, since OCaml ecosystem transitioning to many compiler improvements lately, and you often need to switch between different versions in the process of porting.

denysdovhan
denysdovhan requested changes Jul 23, 2019
View reviewed changes
Copy link
Member

@denysdovhan denysdovhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please, resolve the conflict.

@salmanulfarzy salmanulfarzy added the frozen Progress is temporarily frozen until resolving the specific issue. label Sep 20, 2019
@Runrioter Runrioter mentioned this pull request May 17, 2020
Closed
@netlify
Copy link

netlify bot commented Nov 17, 2021 •
edited
Loading

✔️ Deploy Preview for spaceship-prompt ready!

🔨 Explore the source changes: e7f0d37

🔍 Inspect the deploy log: https://app.netlify.com/sites/spaceship-prompt/deploys/61959cad4f97a30008b594a8

😎 Browse the preview: https://deploy-preview-561--spaceship-prompt.netlify.app

@atongen
Copy link
Author

atongen commented Nov 18, 2021

Sorry for the delay on this!

@atongen
Copy link
Author

atongen commented Nov 18, 2021

Hi @salmanulfarzy, is it possible to remove the frozen label from this PR?

@atongen
Copy link
Author

atongen commented Jan 13, 2022

@denysdovhan @salmanulfarzy @Runrioter Is there any interest in getting this merged?

@Runrioter
Copy link
Member

LGTM

@denysdovhan denysdovhan mentioned this pull request Nov 1, 2022
Merged
@denysdovhan
Copy link
Member

🎉 This issue has been resolved in version 4.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@denysdovhan denysdovhan added the released Released issues and PRs label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denysdovhan denysdovhan Awaiting requested review from denysdovhan

@salmanulfarzy salmanulfarzy Awaiting requested review from salmanulfarzy

@Runrioter Runrioter Awaiting requested review from Runrioter

Assignees

@atongen atongen

Labels
frozen Progress is temporarily frozen until resolving the specific issue. new-feature A PR that implement feature (section, specific behavior, etc). released Released issues and PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atongen @salmanulfarzy @Runrioter @denysdovhan @XVilka