Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After updating to 2024.2.4 is the card empty #699

Closed
2 tasks done
anders3408 opened this issue Feb 26, 2024 · 26 comments · Fixed by #702
Closed
2 tasks done

After updating to 2024.2.4 is the card empty #699

anders3408 opened this issue Feb 26, 2024 · 26 comments · Fixed by #702
Labels
bug Something isn't working

Comments

@anders3408
Copy link

anders3408 commented Feb 26, 2024

Before submitting a bug

  • I updated to the latest version available
  • I cleared the cache of my browser

Describe the bug

After updating to 2024.2.4 is the card empty when adding it with the following yaml:

type: custom:vacuum-card
entity: vacuum.roomba

The model is a iRobot Roomba 980 and worked perfectly in version 2024.2.2 and in 2024.2.4 the iRobot works fine with other cards, but this looks much better :)

Steps to reproduce

  1. Go to '...'
  2. Click on '....'
  3. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.
For example, JavaScript errors are shown in the web inspector (if applicable).

Versions:

  • Release: Latest
  • Browser: Chrome, iOS app
  • HomeAssistant version: 2024.2.4
@anders3408 anders3408 added the bug Something isn't working label Feb 26, 2024
@DeFlanko
Copy link

I restarted HA, disabled the Roomba, and re-enabled it and then the card displayed the vacuum again.

@Veldkornet
Copy link

I restarted HA, disabled the Roomba, and re-enabled it and then the card displayed the vacuum again.

Yes, this worked for me too

@diveschumi
Copy link

This worked for me only for one time. The next time the card was not displayed again.

@DeFlanko
Copy link

DeFlanko commented Feb 27, 2024 via email

@anders3408
Copy link
Author

I restarted HA, disabled the Roomba, and re-enabled it and then the card displayed the vacuum again.

Doesn't change anything here sadly.

@Veldkornet
Copy link

I restarted HA, disabled the Roomba, and re-enabled it and then the card displayed the vacuum again.

Doesn't change anything here sadly.

Yeah, it has disappeared for me again

@ethemcemozkan
Copy link

For me the cards are only visible when vacuums are disabled(showing as unavailable), then after reenabling the vacuums cards are not visible

@frontside76
Copy link

Same problem here. The card is empty since the 2024.2.4 Update.

@RamonM77
Copy link

Same here after updating to 2024.2.4.
After disabling/reenabling the integration the card is available, but after een brief period the card is empty again.

@sebPomme
Copy link

Just to say, same problem here 2024.2.4

@JBenson74
Copy link

I'm having the same problem with ONE of two vacuums:

  1. An iRobot Roomba 980, the same as the OP.
    This machine does not show up in custom:vacuum-card since 2024.2.4
    It appears like this in Developer Tools:
vacuum.roomba (State: docked)
battery_level: 30
battery_icon: mdi:battery-charging-20
software_version: v2.4.17-138
status: null
position: (208, -35, 8)
bin_present: true
bin_full: false
friendly_name: Roomba
supported_features: 13148
  1. A Eufy G30 Hybrid: Provided by a custom integration.
    This machine DOES still work with custom:vacuum-card:
vacuum.robovac
State: docked
fan_speed_list: Standard, Turbo, Max, Boost IQ
friendly_name: RoboVac
supported_features: 16252
battery_level: 100
battery_icon: mdi:battery-charging-100
cleaning_area: 43
cleaning_time: 5280
mode: Nosweep
friendly_name: RoboVac
supported_features: 16252

@DeFlanko
Copy link

DeFlanko commented Feb 28, 2024

@denysdovhan is what happening over in this issue/hotfix affecting this card? home-assistant/core#111210

@frontside76
Copy link

@denysdovhan is what happening over in this issue/hotfix affecting this card? home-assistant/core#111210

After last update 2024.2.4 Roomba and his entities are working again, but not the vaccuum card. The card is empty now.

@MasterDevwi
Copy link

+1, I'm unable to get the restart/disable/enable fix to work, but I've already restarted HA a few times.

@DjRicko
Copy link

DjRicko commented Feb 29, 2024

Disable/Enable fixes it if you're quick to open the effected dashboard while it's still unavailable, then it'll show card untill you refresh dashboard again. Something broke in this update.

@ristomatti
Copy link
Contributor

Can someone confirm if my changes on #702 will fix the issues to you as well? You can do that by temporarily using my fork ristomatti/vacuum-card by adding it to custom repositories. Just remember to change it back if/when the issue gets fixed here. 🙂

@tom3q
Copy link

tom3q commented Mar 1, 2024

Can someone confirm if my changes on #702 will fix the issues to you as well? You can do that by temporarily using my fork ristomatti/vacuum-card by adding it to custom repositories. Just remember to change it back if/when the issue gets fixed here. 🙂

Worked for me. Thanks for the fix!

@PetrP2B
Copy link

PetrP2B commented Mar 1, 2024

Great job, thanks.

@RamonM77
Copy link

RamonM77 commented Mar 1, 2024

That did the trick! Thanks 👍

@kbarnes3
Copy link

kbarnes3 commented Mar 2, 2024

This didn't work for me. My methodology was:

  • Clone ristomatti's repo and checkout bug/get-status-fails (commit 182afbe)
  • Run npm install and npm run build
  • Insert a comment on the top line of the resulting dist/vacuum-card.js to make sure it is getting downloaded
  • Create vacuum-card.js.gz from the newly created vacuum-card.js
  • Upload both of these to /config/www/community/vacuum-card/
  • CTRL+F5 and confirm the new file is downloaded using debug tools
  • Observe the vacuum cards for my Roomba's are still missing.

Are there any steps I'm missing?

@ristomatti
Copy link
Contributor

@kbarnes3 Is the official vacuum card also loaded perhaps? Do you see any error on the devtools console? In my case it was pretty obvious:

    Uncaught (in promise) TypeError: Cannot read properties of null (reading 'toLowerCase')
        at qr.renderStatus (vacuum-card.js?hacstag=261291295280:4:14674)
        at qr.render (vacuum-card.js?hacstag=261291295280:4:17680)
        at qr.update (vacuum-card.js?hacstag=261291295280:1:15173)
        at qr.performUpdate (vacuum-card.js?hacstag=261291295280:1:6493)
        at qr.scheduleUpdate (vacuum-card.js?hacstag=261291295280:1:6140)
        at qr._$Ej (vacuum-card.js?hacstag=261291295280:1:6048)

I didn't try installing it manually, just went straight on creating a custom repo to see if the change worked. 😁

@kbarnes3
Copy link

kbarnes3 commented Mar 2, 2024

@ristomatti
You are right, it looks like I had some weird caching going on. I updated the cache-busting number at the end of the Dashboard Resources settings and now I'm getting the new version and things look good again!

@Zackptg5
Copy link

Zackptg5 commented Mar 2, 2024

I was having issues adding custom repo too. I just removed the original vacuum card and manually downloaded the one from the fork, working fine now

@Ziris85
Copy link

Ziris85 commented Mar 5, 2024

Came looking for this very issue. Tried and confirmed that @ristomatti 's fork seems to resolve my issue (Roomba card empty, Shark card functional). Thank you! I see the Ukraine banner on this github project and notice that the original author doesn't appear to have been active for quite some time. Hopefully they're OK.

@DeFlanko
Copy link

DeFlanko commented Mar 5, 2024

Can someone confirm if my changes on #702 will fix the issues to you as well? You can do that by temporarily using my fork ristomatti/vacuum-card by adding it to custom repositories. Just remember to change it back if/when the issue gets fixed here. 🙂

Got it back Thanks Coach!

image

@ristomatti
Copy link
Contributor

FYI @RamonM77 @petrepa @tom3q @Zackptg5 @DeFlanko @Ziris85 @kbarnes3, I can confirm this is now fixed with vacuum-card v2.8.1, please remove the custom repository. I'll keep it available for some time but eventually I'll delete it. Thank you for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.