Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sinhala translation #130

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Sinhala translation #130

merged 1 commit into from
Feb 22, 2021

Conversation

pavinduLakshan
Copy link
Contributor

referencing #93

denysdovhan
denysdovhan requested changes Oct 19, 2020
View reviewed changes
Copy link
Owner

@denysdovhan denysdovhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should include a link to your translation in the main README.md file.

Also, find someone to check and approve your translation. Thanks!

@denysdovhan denysdovhan added translation Translation requests help wanted We're looking for help on this issue or PR labels Oct 19, 2020
@pavinduLakshan
Copy link
Contributor Author

@denysdovhan, First off, thanks for having a look at my PR, but I have a little thing to clarify.

Also, find someone to check and approve your translation. Thanks!

can you kindly explain what should I exactly do?

@denysdovhan
Copy link
Owner

@pavinduLakshan find someone who speaks your language to check and approve your translation. I need to make sure your translation is well and readable.

@denysdovhan
Copy link
Owner

@pavinduLakshan Any update? Did you find someone to review it?

@Udith-Gayan
Copy link

@denysdovhan Hi, As per @pavinduLakshan's request, I started reviewing his changes, as a native speaker of Sinhalese. I need some time to review it. Once my review is over, I'll give my comment. Thank you

@Udith-Gayan
Copy link

Hi @denysdovhan, I reviewed the file edited by @pavinduLakshan . The translation is in a quite good state and well readable. I didn't even see any typo and I felt that he had done the translation very carefully.
Thank you.

@denysdovhan denysdovhan merged commit b5df627 into denysdovhan:master Feb 22, 2021
@denysdovhan
Copy link
Owner

Thanks for contributing!

github-actions bot pushed a commit that referenced this pull request Feb 22, 2021
@semantic-release-bot
chore(release): 1.20.0 [skip ci]
5e3829a 
# [1.20.0](v1.19.1...v1.20.0) (2021-02-22)

### Features

* Sinhala translation ([#130](#130)) ([b5df627](b5df627))
@github-actions
Copy link

🎉 This PR is included in version 1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Issues and PRs released by semantic-release label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denysdovhan denysdovhan denysdovhan requested changes

Assignees
No one assigned
Labels
help wanted We're looking for help on this issue or PR released Issues and PRs released by semantic-release translation Translation requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pavinduLakshan @denysdovhan @Udith-Gayan