Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm package #18

Open
mweibel opened this issue Apr 4, 2016 · 3 comments
Open

Update npm package #18

mweibel opened this issue Apr 4, 2016 · 3 comments

Comments

@mweibel
Copy link
Contributor

mweibel commented Apr 4, 2016

Hi,

the npm package seems to be quite outdated and nowadays reports a peerDependency error:

» npm install --save dissolve
npm WARN engine dissolve@0.3.3: wanted: {"node":"~0.10.0"} (current: {"node":"5.3.0","npm":"3.3.12"})
npm WARN engine dissolve@0.3.3: wanted: {"node":"~0.10.0"} (current: {"node":"5.3.0","npm":"3.3.12"})
node-etf@0.0.1 /path/to/code/node-etf
└─┬ dissolve@0.3.3
  ├─┬ bl@0.7.0
  │ └── readable-stream@1.0.33
  ├─┬ readable-stream@1.1.13
  │ ├── core-util-is@1.0.2
  │ ├── inherits@2.0.1
  │ ├── isarray@0.0.1
  │ └── string_decoder@0.10.31
  └── UNMET PEER DEPENDENCY stream-browserify@*

npm WARN EPEERINVALID bl@0.7.0 requires a peer of stream-browserify@* but none was installed.
npm WARN EPACKAGEJSON node-etf@0.0.1 No repository field.

Is there a possibility you could update it on npm and maybe also check if newer node version would be doable?

@deoxxa
Copy link
Owner

deoxxa commented Apr 4, 2016

That's not a peer dependency of dissolve - that seems to be related to node-etf. You can see here that as of right now, dissolve has no peer dependencies.

The node and npm versions could probably do with updating, but they're not factually incorrect. dissolve has only been confirmed to run correctly on node ~0.10.0. Feel free to run the test suite and put dissolve through its paces on a later version of node, then submit a pull request updating the compatible versions in package.json. Thanks!

@mweibel
Copy link
Contributor Author

mweibel commented Apr 5, 2016

@deoxxa dissolve 0.3.3 depends on bl ^0.7.0 which removed in rvagg/bl@6aa0713 the peer dependencies.

You can see here that as of right now, dissolve has no peer dependencies.

Yes, current master of dissolve has an updated bl dependency but this is not published on npm. The version itself didn't get increased either (i.e. on npm it's 0.3.3 as well as on the repo itself it's 0.3.3).

I'll gladly do the update for node and will start with that now, but please publish a new version of dissolve as well :)

@yomed
Copy link

yomed commented Mar 10, 2017

Ran into this recently, as well. Would be great if you could publish a newer version to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants