Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade supported node versions #19

Merged
merged 4 commits into from Apr 21, 2016

Conversation

mweibel
Copy link
Contributor

@mweibel mweibel commented Apr 5, 2016

Related to #18

@@ -4,7 +4,7 @@
"description": "Parse and consume binary streams with a neat DSL",
"main": "index.js",
"engines": {
"node": "~0.10.0"
"node": ">= 0.10.0 <= 5.10.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this version specifier is a good idea. What about >=0.10.0 <= 5 instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah, sounds like a good idea. Not sure if that's accepted by npm but I'll check. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -4,7 +4,7 @@
"description": "Parse and consume binary streams with a neat DSL",
"main": "index.js",
"engines": {
"node": ">= 0.10.0 <= 5.10.0"
"node": ">= 0.10.0 ^5"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually work? I updated my previous comment to say >= 0.10.0 <= 5. >= 0.10 <= 5 would be even easier on the eyes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@mweibel
Copy link
Contributor Author

mweibel commented Apr 21, 2016

Ping?

@arthurschreiber arthurschreiber merged commit b178ecc into deoxxa:master Apr 21, 2016
@arthurschreiber
Copy link
Collaborator

Thanks for the changes! ❤️ I'm not sure when I'll get around to releasing this, tho. I'll try my best.

@mweibel
Copy link
Contributor Author

mweibel commented Apr 25, 2016

Would be nice to have it, maybe you could consider semantic-release :)

FYI I used dissolve in mweibel/node-etf and it's working great :) Also it's somewhat complex and still easily readable. Thanks for that!

@arthurschreiber
Copy link
Collaborator

semantic-release looks really nice. Do you think you could open a PR that includes all the changes to make it work? I'm not sure whether I'll be able to find the time to set this up.

@mweibel
Copy link
Contributor Author

mweibel commented Apr 26, 2016

I'll look at it, yep! Requires changing the commit guidelines to something like the AngularJS commit guidelines (that's what I use and they recommend) and recommends using cz-cli for doing that. Not sure if you're up for that?

@arthurschreiber
Copy link
Collaborator

That sounds fine, I wouldn't mind, and @deoxxa is probably 👍 with everything that reduces his workload. 😄

@deoxxa
Copy link
Owner

deoxxa commented Apr 26, 2016

Correct!

@deoxxa
Copy link
Owner

deoxxa commented Apr 26, 2016

You're doing a great job with all this by the way, @arthurschreiber - thanks for keeping this little project kicking along :)

@mweibel
Copy link
Contributor Author

mweibel commented Apr 27, 2016

@arthurschreiber apparently it's not easy to set that up if you're not a contributor on github & listed as an owner on npm.

Easiest for you would be to follow the following steps to achieve automation:

npm install -g semantic-release-cli commitizen
commitizen init cz-conventional-changelog --save-dev --save-exact
semantic-release-cli setup

Then commit & push

@mweibel mweibel deleted the feature/upgrade-node branch April 27, 2016 15:54
@mweibel mweibel restored the feature/upgrade-node branch April 27, 2016 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants