New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade supported node versions #19
Conversation
@@ -4,7 +4,7 @@ | |||
"description": "Parse and consume binary streams with a neat DSL", | |||
"main": "index.js", | |||
"engines": { | |||
"node": "~0.10.0" | |||
"node": ">= 0.10.0 <= 5.10.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this version specifier is a good idea. What about >=0.10.0 <= 5
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yeah, sounds like a good idea. Not sure if that's accepted by npm but I'll check. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -4,7 +4,7 @@ | |||
"description": "Parse and consume binary streams with a neat DSL", | |||
"main": "index.js", | |||
"engines": { | |||
"node": ">= 0.10.0 <= 5.10.0" | |||
"node": ">= 0.10.0 ^5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this actually work? I updated my previous comment to say >= 0.10.0 <= 5
. >= 0.10 <= 5
would be even easier on the eyes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Ping? |
Thanks for the changes! ❤️ I'm not sure when I'll get around to releasing this, tho. I'll try my best. |
Would be nice to have it, maybe you could consider semantic-release :) FYI I used dissolve in mweibel/node-etf and it's working great :) Also it's somewhat complex and still easily readable. Thanks for that! |
|
I'll look at it, yep! Requires changing the commit guidelines to something like the AngularJS commit guidelines (that's what I use and they recommend) and recommends using cz-cli for doing that. Not sure if you're up for that? |
That sounds fine, I wouldn't mind, and @deoxxa is probably 👍 with everything that reduces his workload. 😄 |
Correct! |
You're doing a great job with all this by the way, @arthurschreiber - thanks for keeping this little project kicking along :) |
@arthurschreiber apparently it's not easy to set that up if you're not a contributor on github & listed as an owner on npm. Easiest for you would be to follow the following steps to achieve automation:
Then commit & push |
Related to #18