Skip to content

Commit

Permalink
Revert to pre-v0.1.0 code requirements
Browse files Browse the repository at this point in the history
  • Loading branch information
zertosh committed Nov 8, 2015
1 parent a6830be commit aa31a12
Show file tree
Hide file tree
Showing 9 changed files with 273 additions and 223 deletions.
12 changes: 0 additions & 12 deletions .editorconfig

This file was deleted.

1 change: 0 additions & 1 deletion .gitattributes

This file was deleted.

3 changes: 1 addition & 2 deletions .gitignore
@@ -1,2 +1 @@
coverage
node_modules
/node_modules
23 changes: 4 additions & 19 deletions .travis.yml
@@ -1,22 +1,7 @@
sudo: false
branches:
except: /^v\d/
language: node_js
node_js:
- stable
- '0'
- '0.10'
before_install: if [[ `npm --version` != 3* ]]; then npm install -g npm; fi;
script: >-
if [[ `node --version` == v0.* ]];
then npm install babel@5 &&
node node_modules/.bin/babel test.js --out-file test.js &&
node test.js;
else npm test;
fi;
after_script: >-
if [[ `node --version` != v0.* ]];
then npm install istanbul-coveralls@1 &&
npm run-script coverage &&
node node_modules/.bin/istanbul-coveralls;
fi;
- "0.10"
- "0.12"
- "4"
- "5"
60 changes: 41 additions & 19 deletions README.md
Expand Up @@ -3,31 +3,53 @@
Like [duplexer](https://github.com/Raynos/duplexer) but using Streams3

```javascript
const duplexer2 = require(".");
const {Readable, Writable} = require("stream");

const writable = new Writable({
write(data, enc, cb) {
if (readable.push(data)) {
cb();
return;
}
readable.once("drain", cb);
var stream = require("stream");

var duplexer2 = require("duplexer2");

var writable = new stream.Writable({objectMode: true}),
readable = new stream.Readable({objectMode: true});

writable._write = function _write(input, encoding, done) {
if (readable.push(input)) {
return done();
} else {
readable.once("drain", done);
}
});
};

const readable = new Readable({read() {/* no-op */}});
readable._read = function _read(n) {
// no-op
};

// simulate the readable thing closing after a bit
writable.once("finish", () => setTimeout(() => readable.push(null), 300));
writable.once("finish", function() {
setTimeout(function() {
readable.push(null);
}, 500);
});

var duplex = duplexer2(writable, readable);

duplex.on("data", function(e) {
console.log("got data", JSON.stringify(e));
});

duplex.on("finish", function() {
console.log("got finish event");
});

const duplex = duplexer2({}, writable, readable)
.on("data", data => console.log("got data", data.toString()))
.on("finish", () => console.log("got finish event"))
.on("end", () => console.log("got end event"));
duplex.on("end", function() {
console.log("got end event");
});

duplex.write("oh, hi there", () => console.log("finished writing"));
duplex.end(() => console.log("finished ending"));
duplex.write("oh, hi there", function() {
console.log("finished writing");
});

duplex.end(function() {
console.log("finished ending");
});
```

```
Expand Down
66 changes: 44 additions & 22 deletions example.js
@@ -1,27 +1,49 @@
#!/usr/bin/env node --harmony_destructuring
"use strict";

const duplexer2 = require(".");
const {Readable, Writable} = require("stream");

const readable = new Readable({read() {/* no-op */}});
const writable = new Writable({
write(data, enc, cb) {
if (readable.push(data)) {
cb();
return;
}
readable.once("drain", cb);
#!/usr/bin/env node

var stream = require("readable-stream");

var duplexer2 = require("./");

var writable = new stream.Writable({objectMode: true}),
readable = new stream.Readable({objectMode: true});

writable._write = function _write(input, encoding, done) {
if (readable.push(input)) {
return done();
} else {
readable.once("drain", done);
}
});
};

readable._read = function _read(n) {
// no-op
};

// simulate the readable thing closing after a bit
writable.once("finish", () => setTimeout(() => readable.push(null), 300));
writable.once("finish", function() {
setTimeout(function() {
readable.push(null);
}, 500);
});

var duplex = duplexer2(writable, readable);

const duplex = duplexer2({}, writable, readable)
.on("data", data => console.log("got data", data.toString()))
.on("finish", () => console.log("got finish event"))
.on("end", () => console.log("got end event"));
duplex.on("data", function(e) {
console.log("got data", JSON.stringify(e));
});

duplex.on("finish", function() {
console.log("got finish event");
});

duplex.on("end", function() {
console.log("got end event");
});

duplex.write("oh, hi there", function() {
console.log("finished writing");
});

duplex.write("oh, hi there", () => console.log("finished writing"));
duplex.end(() => console.log("finished ending"));
duplex.end(function() {
console.log("finished ending");
});
12 changes: 2 additions & 10 deletions package.json
Expand Up @@ -6,9 +6,7 @@
"index.js"
],
"scripts": {
"pretest": "eslint --config @shinnn/node-legacy --rule 'quotes: [2, double]' example.js --rule 'no-underscore-dangle: 0' index.js test.js",
"test": "node --strong_mode --harmony_destructuring --harmony_rest_parameters --harmony_spreadcalls --throw-deprecation --trace-sync-io --track-heap-objects test.js | tap-spec",
"coverage": "node --strong_mode --harmony_destructuring --harmony_rest_parameters --harmony_spreadcalls node_modules/.bin/istanbul cover test.js"
"test": "mocha -R tap"
},
"repository": "deoxxa/duplexer2",
"keywords": [
Expand All @@ -25,12 +23,6 @@
"readable-stream": "^2.0.2"
},
"devDependencies": {
"@shinnn/eslint-config-node-legacy": "^1.0.0",
"eslint": "^1.7.1",
"istanbul": "^0.3.22",
"object-assign": "^4.0.1",
"tap-spec": "^4.1.0",
"tape": "^4.2.1",
"through": "^2.3.8"
"mocha": "^2.2.5"
}
}
138 changes: 0 additions & 138 deletions test.js

This file was deleted.

0 comments on commit aa31a12

Please sign in to comment.