New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDF Generator - Demo Endpoint + Redis #143
Conversation
…erans-affairs/abd-vro into pdf-generator-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I tested it with postman with some sample data and it worked perfectly. On possible improvement would be to change the fetch_pdf endpoint to only require the "claimSubmissionId" field because it does not need the "evidence" to return the right pdf, but that is not absolutely necessary so I will approve.
Let's remove/rename the |
import java.io.ByteArrayInputStream; | ||
import java.io.InputStream; | ||
import java.util.Base64; | ||
|
||
@Slf4j | ||
@RestController | ||
public class DemoController implements DemoResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you've modified it to be used for the new endpoints that will be called by RRD, this DemoController
class should be removed/renamed and put in a different Java package.
PDF Generator - Demo Endpoint + Redis
Description
What was the problem?
Incorrect API endpoint for the PDF generator
How does this fix it?
Update the previous demo endpoint to use the new fields based on #113. Added Redis instead of using S3 to store the PDF file and split the functionality into 2 endpoints, a generate and a fetch request.
How to test this PR
More details in README.md
Request Body:
You can fill
evidence
with additional information as long as it matches the format in Assess Claims here: #113