Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for test coverage reports via pytest-cov. #2989

Merged
merged 1 commit into from
May 14, 2024

Conversation

dfitchett
Copy link
Contributor

What was the problem?

EE projects did not include test coverage.

Associated tickets or Slack threads:

How does this fix it?[^1]

Adds pytest-cov to domain-ee subprojects.

How to test this PR

  • Run via gradle: ./gradlew :domain-ee:test
  • Run via pytest from individual project folder

@dfitchett dfitchett requested a review from a team as a code owner May 14, 2024 19:27
Copy link

Test Results

109 tests  ±0   109 ✅ ±0   35s ⏱️ -1s
 33 suites ±0     0 💤 ±0 
 33 files   ±0     0 ❌ ±0 

Results for commit 6e0d6ac. ± Comparison against base commit 9e49b41.

Copy link

JaCoCo Test Coverage

Overall Project 64.3%

There is no coverage information present for the Files changed

Copy link
Contributor

@nanotone nanotone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, with the understanding that this change doesn't incorporate test coverage reports into GitHub PR feedback.

@dfitchett
Copy link
Contributor Author

Approving, with the understanding that this change doesn't incorporate test coverage reports into GitHub PR feedback.

Seemed like more work than it was worth. If there isn't 80% pytest coverage, then the code check will fail.

@dfitchett dfitchett merged commit 2024bf9 into develop May 14, 2024
16 of 17 checks passed
@dfitchett dfitchett deleted the dfitchett/domain-ee/test-coverage branch May 14, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants