Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store description field into RDS from kafka payload #2994

Merged
merged 6 commits into from
May 21, 2024
Merged

Store description field into RDS from kafka payload #2994

merged 6 commits into from
May 21, 2024

Conversation

chengjie8
Copy link
Collaborator

@chengjie8 chengjie8 commented May 16, 2024 •
edited

Associated tickets or Slack threads:

How does this fix it?1

  • Added the @nologging annotation.
  • Applied the annotation to the description field.
  • Overrode the toString method to prevent printing the field value if the @nologging annotation is present.
  • Made backend changes to store the value of the description field in the database.

How to test this PR

  • verify description field in stored in RDS db

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩

@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited

Test Results

109 tests  ±0   109 ✅ ±0   34s ⏱️ -2s
 33 suites ±0     0 💤 ±0 
 33 files   ±0     0 ❌ ±0 

Results for commit 10da01b. ± Comparison against base commit 378ef8a.

♻️ This comment has been updated with latest results.

@chengjie8 chengjie8 changed the title added new annotation for no logging and backend changes to store desc… Store description field into RDS from kafka payload May 20, 2024
@chengjie8 chengjie8 marked this pull request as ready for review May 20, 2024 16:14
@chengjie8 chengjie8 requested a review from a team as a code owner May 20, 2024 16:14
@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited

JaCoCo Test Coverage

Overall Project 65.91% -0.08% ❌
Files changed 96% 🍏

File Coverage
DbHelper.java 100% 🍏
ContentionEventEntity.java 100% 🍏
BieMessagePayload.java 95.77% -4.23% 🍏

nelsestu
nelsestu approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@nelsestu nelsestu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, like a straightforward column addition should get implemented.

@nelsestu nelsestu removed the request for review from msnwatson May 20, 2024 23:22
@chengjie8 chengjie8 merged commit f2dbf5b into develop May 21, 2024
4 checks passed
@chengjie8 chengjie8 deleted the chengjie8/issue-2810 branch May 21, 2024 13:53
msnwatson pushed a commit that referenced this pull request May 23, 2024
@chengjie8 @msnwatson
Store description field into RDS from kafka payload (#2994)
75cb9f9 
* added new annotation for no logging and backend changes to store description value

* minor fix

* spotlesscheck fix

* spotlesscheck fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsestu nelsestu nelsestu approved these changes

@tejans24 tejans24 tejans24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chengjie8 @nelsestu @tejans24