Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug xample-domain integration test #2996

Merged
merged 4 commits into from
May 17, 2024
Merged

debug xample-domain integration test #2996

merged 4 commits into from
May 17, 2024

Conversation

lisac
Copy link
Contributor

@lisac lisac commented May 16, 2024

What was the problem?

debugging what appears to be a CI failure in the xample-domain/integration-test consistent across the past few days :

Task :dockerComposeUp FAILED
[...]
Service "rabbitmq-service" was pulled in as a dependency of service "svc-bip-api" but is not enabled by the active profiles. You may fix this by adding a common profile to "rabbitmq-service" and "svc-bip-api".

sample of CI failures on develop: May 16, May 14, May 13

How does this fix it?

  • modify the COMPOSE_PROFILES for the xample-domain CI workflow
  • remove section of the affected integration test that was referencing a removed app

How to test this PR

Verify that the CI tests on xample-domain are informative and do not fail. sample successful run observed on c503557.

@lisac lisac self-assigned this May 16, 2024
Copy link

github-actions bot commented May 16, 2024

Test Results

109 tests  ±0   109 ✅ ±0   34s ⏱️ ±0s
 33 suites ±0     0 💤 ±0 
 33 files   ±0     0 ❌ ±0 

Results for commit 243347a. ± Comparison against base commit e12854e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 16, 2024

JaCoCo Test Coverage

Overall Project 65.36%

There is no coverage information present for the Files changed

@lisac lisac marked this pull request as ready for review May 16, 2024 21:29
@lisac lisac requested a review from a team as a code owner May 16, 2024 21:29
@lisac lisac requested review from tejans24 and chengjie8 May 16, 2024 21:29
lisac added 4 commits May 16, 2024 18:09
debugging a CI failure: 
>  Service "rabbitmq-service" was pulled in as a dependency of service "svc-bip-api" but is not enabled by the active profiles. You may fix this by adding a common profile to "rabbitmq-service" and "svc-bip-api".
why: the VRO app has been removed from the codebase
Copy link
Collaborator

@tejans24 tejans24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for removing the cruft @lisac

@lisac lisac merged commit 378ef8a into develop May 17, 2024
17 of 18 checks passed
@lisac lisac deleted the lisac-patch-1 branch May 17, 2024 16:39
msnwatson pushed a commit that referenced this pull request May 23, 2024
* set COMPOSE_PROFILES to "platform"

debugging a CI failure: 
>  Service "rabbitmq-service" was pulled in as a dependency of service "svc-bip-api" but is not enabled by the active profiles. You may fix this by adding a common profile to "rabbitmq-service" and "svc-bip-api".

* remove nondraft-pr condition for xample-domain CI test

* remove CI tests against vro-app 

why: the VRO app has been removed from the codebase

* restore CI workflow configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants