shots in the dark

department-of-veterans-affairs · May 14, 2020 · 47d2089 · 47d2089
1 parent 2623387
commit 47d2089
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/services/pdf_service.rb b/app/services/pdf_service.rb
@@ -14,7 +14,7 @@ def self.write(filename, contents, pdf_attributes)
 
     # pdftk will crash on corrupt PDFs with the "Error: Unable to find file";
     # if this happens, write the file without attributes
-    unless stderr.empty?
+    unless stderr.blank?
       # contents might come back as nil
       Rails.logger.warn("cannot write pdf of size #{contents.try(:size).to_i} via #{command}: #{stderr}")
       File.open(filename, "wb") do |f|

diff --git a/app/services/zipfile_creator.rb b/app/services/zipfile_creator.rb
@@ -7,7 +7,7 @@ class ZipfileCreator
 
   def process
     records = manifest.records
-    return if records.empty?
+    return if records.blank?
 
     t = Tempfile.new
     write_to_tempfile(t, records)