Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table header scrolls with the doc manifest #574

Closed
lakohl opened this issue Aug 3, 2017 · 9 comments
Closed

Table header scrolls with the doc manifest #574

lakohl opened this issue Aug 3, 2017 · 9 comments
Assignees

Comments

@lakohl
Copy link

lakohl commented Aug 3, 2017

As a user I would like to be able to see the column labels when I scroll through the list of files eX is retrieving, so I can better understand the content of each column.
Currently the table headings scroll with the doc list :(

AC

  1. Ensure the table header contains the following column headers (listed here from left to right): Document Type, Source, Receipt Date.
  2. Ensure that table header is always visible on the Start Retrieving eFolder page
  3. Ensure the table header is always visible on the Retrieving eFolder page
  4. Ensure the table header is always visible on the Download eFolder page
@lakohl
Copy link
Author

lakohl commented Aug 3, 2017

@Sjones352 if you are already working on fixing this, please assign this issue to yourself :)

@Sjones352
Copy link
Contributor

Currently. Still a few things to fix
header

@lakohl
Copy link
Author

lakohl commented Aug 9, 2017

Awesome 😀

@lakohl
Copy link
Author

lakohl commented Aug 9, 2017

Can the table headers also retain the grey background?

@Sjones352
Copy link
Contributor

@lakohl yes the table headers retain the grey background

header

@lakohl
Copy link
Author

lakohl commented Aug 10, 2017

@Sjones352 I noticed that on the 'Start retrieving eFolder' page (the first page after the loading spinner), the far right table header still says 'Upload Date' instead of 'Receipt Date'.

I updated the AC to fix this as well.

Sjones352 added a commit that referenced this issue Aug 10, 2017
 Persistent table headers (#574)

 Connects to Table header scrolls with the doc manifest (#574)

* adjusted the email on help page to be a link
@ghost
Copy link

ghost commented Aug 11, 2017

The header scrolls if you...uh... scroll the header... weird:

  • Hover over the header and try scrolling
  • Weird.
    header

@ghost ghost added In Progress and removed In Validation labels Aug 11, 2017
Sjones352 added a commit that referenced this issue Aug 11, 2017
Table header was hovering once scrolled so removed the scroll in order for header to stay fixed.
@Sjones352
Copy link
Contributor

@kierachell Fixed it and assigned you the PR.

Sjones352 added a commit that referenced this issue Aug 11, 2017
Fixed Table header (#574)
Table header was hovering once scrolled so removed the scroll in order for header to stay fixed.
@ghost
Copy link

ghost commented Aug 11, 2017

PASSED

scroll

@ghost ghost closed this as completed Aug 11, 2017
@ghost ghost removed the In Validation label Aug 11, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants