Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedback page, remove env var for feedback and fix spec test #1094

Merged
merged 3 commits into from May 13, 2019

Conversation

nemodjuric
Copy link
Contributor

Merge date should be on/after May 13.

Resolves department-of-veterans-affairs/caseflow#10257

Description

This PR creates Feedback page with status message. Make sure department-of-veterans-affairs/caseflow-frontend-toolkit#50 is merged first before merging (and caseflow-frontend-toolkit version reference updated).

Acceptance Criteria

  • Any 'Send feedback' link in Caseflow app should take to this page

Testing Plan

  1. Go to any page and click 'Send feedback', it should show status message

@ghost ghost assigned nemodjuric May 13, 2019
@ghost ghost added in progress labels May 13, 2019
Copy link
Contributor

@pkarman pkarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@sunil-sadasivan sunil-sadasivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but the changes look 👍 from my eyes. Thanks Nemo!

@nemodjuric nemodjuric merged commit d6972bc into master May 13, 2019
@ghost ghost removed In-Progress labels May 13, 2019
@pkarman pkarman deleted the nemo/feedback branch July 18, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback Deprecation Effort | Change Feedback Behavior
3 participants