Remove user_authorizer feature toggle

app/controllers/api/v2/application_controller.rb

@@ -27,14 +27,6 @@ def verify_veteran_file_number
   end
 
   def fetch_veteran_by_file_number(file_number)
-    if FeatureToggle.enabled?(:user_authorizer, user: current_user)
-      fetch_veteran_with_user_authorizer(file_number)
-    else
-      fetch_veteran_with_bgs_service(file_number)
-    end
-  end
-
-  def fetch_veteran_with_user_authorizer(file_number)
     Rails.logger.debug("UserAuthorizer for #{file_number} and current_user #{current_user.css_id}")
     authorizer = UserAuthorizer.new(user: current_user, file_number: file_number)
     if authorizer.can_read_efolder? && authorizer.veteran_record_found?
@@ -49,18 +41,4 @@ def fetch_veteran_with_user_authorizer(file_number)
       raise BGS::ShareError, "Cannot access Veteran record"
     end
   end
-
-  def fetch_veteran_with_bgs_service(file_number)
-    begin
-      veteran_info = bgs_service.fetch_veteran_info(file_number)
-    rescue StandardError => e
-      return sensitive_record if e.message.include?("Sensitive File - Access Violation")
-      return vso_denied_record if e.message.include?("Power of Attorney of Folder is")
-      raise e
-    end
-
-    return veteran_not_found(file_number) unless bgs_service.record_found?(veteran_info)
-
-    veteran_info["file_number"] || file_number
-  end
 end

app/models/veteran.rb

@@ -41,15 +41,11 @@ def set_attrs_from_bgs_record
   def fetch_bgs_record
     return bgs.fetch_veteran_info(file_number) unless user
 
-    if FeatureToggle.enabled?(:user_authorizer, user: user)
-      if authorizer.can_read_efolder? && authorizer.veteran_record_found?
-        # use .system_veteran_record in case we are POA and .veteran_record is nil
-        authorizer.system_veteran_record
-      else
-        raise BGS::ShareError, "Cannot access Veteran record"
-      end
+    if authorizer.can_read_efolder? && authorizer.veteran_record_found?
+      # use .system_veteran_record in case we are POA and .veteran_record is nil
+      authorizer.system_veteran_record
     else
-      bgs.fetch_veteran_info(file_number)
+      raise BGS::ShareError, "Cannot access Veteran record"
     end
   end
 end

spec/controllers/api_v2_application_controller_spec.rb

@@ -68,14 +68,6 @@ def index
 
   let(:body) { JSON.parse(response.body, symbolize_names: true) }
 
-  before do
-    FeatureToggle.enable!(:user_authorizer)
-  end
-
-  after do
-    FeatureToggle.disable!(:user_authorizer)
-  end
-
   describe "veteran file number access" do
     before do
       request.headers.merge!(headers)

spec/features/user_error_flows_spec.rb

@@ -100,31 +100,7 @@
     end
   end
 
-  context "When veteran id has high sensitivity" do
-    scenario "Cannot access it" do
-      allow_any_instance_of(Fakes::BGSService).to receive(:fetch_veteran_info).and_raise("Sensitive File - Access Violation")
-      visit "/"
-      fill_in "Search for a Veteran ID number below to get started.", with: veteran_id
-      click_button "Search"
-
-      expect(page).to have_content("This efolder contains sensitive information")
-    end
-
-    scenario "VSO cannot access it" do
-      allow_any_instance_of(Fakes::BGSService).to receive(:fetch_veteran_info)
-        .and_raise("Power of Attorney of Folder is '071'. Access to this record is denied.")
-      visit "/"
-      fill_in "Search for a Veteran ID number below to get started.", with: veteran_id
-      click_button "Search"
-
-      expect(page).to have_content("This efolder belongs to a Veteran you do not represent")
-    end
-  end
-
-  context "user_authorizer feature toggle on" do
-    before { FeatureToggle.enable!(:user_authorizer) }
-    after { FeatureToggle.disable!(:user_authorizer) }
-
+  context "UserAuthorizer" do
     let(:veteran_participant_id) { "123" }
     let(:poa_participant_id) { "345" }
 

spec/requests/api/v2/manifests_spec.rb

@@ -298,9 +298,6 @@ def documents
   end
 
   context "POA" do
-    before { FeatureToggle.enable!(:user_authorizer) }
-    after { FeatureToggle.disable!(:user_authorizer) }
-
     subject { post "/api/v2/manifests/", params: nil, headers: headers }
 
     let(:veteran_info) do