Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task Model Callback Untangling #13058

Closed
lomky opened this issue Dec 24, 2019 · 1 comment
Closed

Task Model Callback Untangling #13058

lomky opened this issue Dec 24, 2019 · 1 comment
Labels
Eng: Backend Work Group backend engineering task Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Tech-Improvement Type: Tech-Spec Label for issues that contain a tech spec

Comments

@lomky
Copy link
Contributor

lomky commented Dec 24, 2019

Description

Create a tech spec evaluating the options for reimplementing our domain logic that is currently all captured as ActiveRecord callbacks on Task, its subclasses, and it's related objects.

Goals:

  • Clear & Understandable flow
  • Independently testable behavior
  • Ability to skip domain behavior without losing validation behavior.

Background/context/resources

Technical notes

Observer Pattern? Concerns? Callbacks, but more intentional? Does Rails have an established best practice? What does Metz suggest? Where does the domain logic go?!

Fell out of #12617/#13057
@jimruggiero jimruggiero added Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests labels Jan 23, 2020
@hschallhorn
Copy link
Contributor

Include documentation on how current model callbacks work in spec.
What is this graph?

1 | 
2 | 
3 | ||||||||
5 | |||||||
8 |

Although is a tech spec, seems like it requires more research than a normal one. Untangling.

@pkarman pkarman mentioned this issue Feb 25, 2020
Merged
va-bot pushed a commit that referenced this issue Feb 28, 2020
@pkarman
Set closed_at inside update_all when we close tasks (#13529)
d442168 
In https://github.com/department-of-veterans-affairs/dsva-vacols/issues/107 we learned that some cancelled tasks do not have a `closed_at` value set.

This PR is a start of remedying that.

See also #13058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Eng: Backend Work Group backend engineering task Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Tech-Improvement Type: Tech-Spec Label for issues that contain a tech spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lomky @hschallhorn @jimruggiero @ThorntonMatthew