Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intake | Bug | Fix asynchronous request issue withdrawals in VBMS #13483

Closed
1 task
leikkisa opened this issue Feb 20, 2020 · 0 comments · Fixed by #14116
Closed
1 task

Intake | Bug | Fix asynchronous request issue withdrawals in VBMS #13483

leikkisa opened this issue Feb 20, 2020 · 0 comments · Fixed by #14116
Assignees
@leikkisa
Labels
Product: caseflow-intake Team: Foxtrot 🦊 Type: Bug
Milestone
PI4-S1: David Hun...

Comments

@leikkisa
Copy link
Contributor

Description

There is a bug in request issue withdrawals which is causing them to not be processed correctly in VBMS unless they're processed synchronously.

Acceptance criteria

  • In RequestIssuesUpdate, withdrawn issues still have their contentions removed in VBMS if processed asynchronously

Background/context/resources

Data cleanup ticket: #13399
Slack thread: https://dsva.slack.com/archives/CFBLH2LR4/p1581530133146400

Technical notes

The other issue processing methods in RequestIssuesUpdate should show a pattern that can be used for accessing withdrawn issues. I believe the bug is that it's using the temporary @request_issues_data for processing withdrawals which is available when the request_issues_update is initialized. The method to fetch withdrawn issues from the DB was removed in a refactor linked below.

#11138
@leikkisa leikkisa mentioned this issue Mar 24, 2020
Closed
@Sjones352 Sjones352 assigned Sjones352 and unassigned Sjones352 Mar 30, 2020
@leikkisa leikkisa self-assigned this Apr 28, 2020
@leikkisa leikkisa mentioned this issue Apr 28, 2020
Merged
@leikkisa leikkisa linked a pull request Apr 28, 2020 that will close this issue
Intake | Bug | Use saved withdrawn issue IDs when processing asynchronously #14116
Merged
@leikkisa leikkisa changed the title Bug | Fix asynchronous request issue withdrawals in VBMS Intake | Bug | Fix asynchronous request issue withdrawals in VBMS Apr 28, 2020
@msj0nes msj0nes added this to the PI4-S1: David Hunter Sprint milestone May 12, 2020
va-bot pushed a commit that referenced this issue May 13, 2020
@leikkisa
Intake | Bug | Use saved withdrawn issue IDs when processing asynchro…
db34a99 
…nously (#14116)

connects #13483

### Description
This adds the ability for request issue withdrawals to fetch withdrawn issues from their IDs saved in the database on the request issues update. This is needed if they are being accessed asynchronously outside of the original update that was submitted which may happen if the VBMS `remove_contention` call fails on the first attempt.

There is a related [manual data fix GitHub issue](#13399) to look for more instances of this and re-attempt processing for them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leikkisa leikkisa

Labels
Product: caseflow-intake Team: Foxtrot 🦊 Type: Bug
Projects
None yet
Milestone
PI4-S1: David Hunter Sprint
4 participants
@leikkisa @Sjones352 @msj0nes @jimruggiero