Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Litigation Support: Create new SendCavcRemandProcessedLetterTask type #15076

Closed
6 tasks
araposo-tistatech opened this issue Aug 27, 2020 · 6 comments · Fixed by #15548
Closed
6 tasks

Litigation Support: Create new SendCavcRemandProcessedLetterTask type #15076

araposo-tistatech opened this issue Aug 27, 2020 · 6 comments · Fixed by #15548
Assignees
@yoomlam
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: New Development New feature development
Projects
Team Echo
Milestone
PI5-S7: Veterans ...

Comments

@araposo-tistatech
Copy link

araposo-tistatech commented Aug 27, 2020 •
edited by hschallhorn
Loading

User or job story

User story: As a Litigation Support, when I have completed the court remand kickoff form and have selected either a JMR or JMPR remand on the form, I need a "SendCavcRemandProcessedLetterTask" task to be created, so that I can take necessary action before sending the letter to an appellant.

Acceptance criteria

  • This feature should be accessible to the following user groups: CAVC Litigation Support
  • Consider better naming of SendCavcRemandProcessedLetterTask
  • SendCavcRemandProcessedLetterTask is created on the new appeal stream as a child of the CAVC task
  • SendCavcRemandProcessedLetterTask is assigned to the CAVC Litigation Support organization as unassigned
  • The Actions drop-down has the following available for the Admin of the organization:
  • Assign to person
  • Once assigned by the Admin of the organization, the Actions drop-down has the following available for the assigned user:
  • Add Admin Action
  • Mark task complete
    • Indicates letter has been sent to veteran

Out of scope

Designs

➡️ UI Designs and flow ⬅️

Background/context

Technical notes

Other notes

Resources/other links
@araposo-tistatech araposo-tistatech added Product: caseflow-queue Team: Echo 🐬 Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Type: New Development New feature development labels Aug 27, 2020
@lpciferri lpciferri mentioned this issue Aug 27, 2020
Closed
12 tasks
@araposo-tistatech araposo-tistatech changed the title Litigation Support: 90 Day Letter Task Litigation Support: Send 90 Day Letter Task Sep 14, 2020
@araposo-tistatech araposo-tistatech mentioned this issue Sep 14, 2020
Closed
6 tasks
@araposo-tistatech araposo-tistatech added the Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests label Sep 14, 2020
@araposo-tistatech
Copy link
Author

@geronimoramos please review and add the designs here. Let me know if I am not capturing this correctly. My understanding is Litigation Support will have a Send 90 Day Letter task, here they will create a POA task (that would block completing the task) as well as any other admin actions as necessary (these would not block completion of the task). The list I added is extensive and will most likely be limited given Litigation Supports response to our question of what admin actions they need available.

I will create another task noting that upon completion of the Send 90 Day Letter task a Parent 90 Day Letter Response task will be created for the Litigation Support team on hold and a child 90 Day Letter Response task will be created or the mail team.

Let me know if the above does not align with you. cc: @mbaenatan @hschallhorn

@mbaenatan
Copy link

This looks good and correct @araposo-tistatech. Still waiting on their guidance on admin actions, but I agree the only change would be to the list of admin actions based on their guidance.

@hschallhorn hschallhorn changed the title Litigation Support: Send 90 Day Letter Task Litigation Support: Create new Send90DayLetterTask type Sep 24, 2020
@hschallhorn hschallhorn changed the title Litigation Support: Create new Send90DayLetterTask type Litigation Support: Create new CavcSend90DayLetterTask type Sep 24, 2020
@hschallhorn hschallhorn changed the title Litigation Support: Create new CavcSend90DayLetterTask type Litigation Support: Create new SendCavcRemandProcessedLetterTask type Sep 24, 2020
@lomky lomky mentioned this issue Oct 23, 2020
Merged
17 tasks
@hschallhorn
Copy link
Contributor

what is this chart?

1 | 
2 | ||
3 | ||||||
5 | |
8 |

Why 2?

  • Standard task creation, plenty of examples

Why 3?

  • Basic addition - mimic existing classes

Why 5?

  • Testing various scenarios

@hschallhorn hschallhorn added this to the PI5-S7: XXX Sprint milestone Nov 2, 2020
@hschallhorn hschallhorn mentioned this issue Nov 2, 2020
Closed
@yoomlam yoomlam self-assigned this Nov 2, 2020
@yoomlam yoomlam mentioned this issue Nov 2, 2020
Merged
8 tasks
@yoomlam
Copy link
Contributor

yoomlam commented Nov 3, 2020 •
edited
Loading

@geronimoramos or @araposo-tistatech

  1. Do we want the Lit Support admin or non-admin to reassign this task to another user?
  2. Do we want an assigned Lit Support non-admin to cancel this task?

@araposo-tistatech
Copy link
Author

@yoomlam below are the answers, @geronimoramos please let me know if you disagree:

  1. Do we want the Lit Support admin or non-admin to reassign this task to another user? Yes

  2. Do we want an assigned Lit Support non-admin to cancel this task? Yes

@araposo-tistatech
Copy link
Author

@yoomlam Correcting #2 above:

Do we want an assigned Lit Support non-admin to cancel this task? Since these are new users and this is the first task we should not give users the ability to cancel the task.

@yoomlam yoomlam added this to In progress in Team Echo Nov 7, 2020
@yoomlam yoomlam moved this from In progress to Review in progress in Team Echo Nov 7, 2020
Team Echo automation moved this from Review in progress to Done Nov 10, 2020
va-bot pushed a commit that referenced this issue Nov 10, 2020
@yoomlam
Add SendCavcRemandProcessedLetterTask (#15548)
a33e191 
Resolves #15076

### Description
Add SendCavcRemandProcessedLetterTask when CavcTask is created.

## Acceptance criteria
- [ ] This feature should be accessible to the following user groups: CAVC Litigation Support
- [ ] Consider better naming of SendCavcRemandProcessedLetterTask 
   - couldn't think of anything better: `SendCavcProcessedLetterTask`, `SendCavcCompleteLetterTask`
- [x] SendCavcRemandProcessedLetterTask is created on the new appeal stream as a child of the CAVC task
- [x] SendCavcRemandProcessedLetterTask is assigned to the CAVC Litigation Support organization as unassigned
- [x] The Actions drop-down has the following available for the Admin of the organization: 
   - Assign to person
- [ ] Once assigned by the Admin of the organization, the Actions drop-down has the following available for the assigned user: 
   - ~Add Admin Action~ Looks like we'll be removing this in #15286, so leaving it out.
   - Mark task complete (Indicates letter has been sent to veteran)

I implemented task reassignment, but only for the user-task (task assigned to a user) not the org-task (task assigned to the CAVC Lit Support org). Reassignment of the org-task will cancel the existing org-task and create a user-task without an org-task parent, which is probably not what we want.

### Testing Plan
1. Create the SendCavcRemandProcessedLetterTask task
```ruby
# Find an appeal with an open DistributionTask to play with
appeal=DistributionTask.open.first.appeal
appeal.treee

distr_task=appeal.tasks.open.where(type: DistributionTask.name).first 
cavc_task=CavcTask.create(appeal: appeal, parent: distr_task)
appeal.reload.treee

send_task=SendCavcRemandProcessedLetterTask.create(appeal: appeal, parent: cavc_task)
appeal.reload.treee
```
1. Sign in as # CAVC_LIT_SUPPORT_ADMIN (VACO) and switch to their [CAVC Lit Support team view](http://localhost:3000/organizations/cavc-lit-support?tab=unassignedTab&page=1). The appeal should be listed in the Unassigned tab.
1. Click on the case; assign task to a CAVC Lit Support team member; check that case is now under the "Assigned" tab.
1. Sign in as the user you assigned it to and go to their queue; click on the case.
1. Play around with task actions, check the case appears in correct queue tab, and check the task tree `appeal.reload.treee`
   * ~ADD_ADMIN_ACTION; cancel it (`Task.where(id: [3374, 3375]).map(&:cancelled!)`) or complete it as the assigned user to have the case assigned back to the assigner. Can also destroy the tasks (`Task.where(id: [3374, 3375]).map(&:destroy)`).~
   * REASSIGN_TO_PERSON
   * MARK_COMPLETE will complete all the way up the tree up to (and including CavcTask since it has no open children tasks).  Can test scenario where CavcTask does have other open children after marking the task complete.
```ruby
                                                      ┌──────────────────────────────────────────────────────────────────────────────────────────────┐
Appeal 9 (evidence_submission) ────────────────────── │ ID   │ STATUS    │ ASGN_BY                │ ASGN_TO                │ UPDATED_AT              │
└── RootTask                                          │ 24   │ on_hold   │                        │ Bva                    │ 2020-11-03 21:30:55 UTC │
    └── DistributionTask                              │ 25   │ on_hold   │                        │ Bva                    │ 2020-11-03 21:30:55 UTC │
        ├── EvidenceSubmissionWindowTask              │ 26   │ assigned  │                        │ MailTeam               │ 2020-11-03 21:30:55 UTC │
        └── CavcTask                                  │ 3369 │ completed │                        │ Bva                    │ 2020-11-04 18:18:39 UTC │
            └── SendCavcRemandProcessedLetterTask     │ 3372 │ completed │                        │ CavcLitigationSupport  │ 2020-11-04 18:18:39 UTC │
                └── SendCavcRemandProcessedLetterTask │ 3373 │ completed │ CAVC_LIT_SUPPORT_ADMIN │ CAVC_LIT_SUPPORT_USER1 │ 2020-11-04 18:18:38 UTC │
                                                      └──────────────────────────────────────────────────────────────────────────────────────────────┘
```

### User Facing Changes
 - [ ] Screenshots of UI changes added to PR & Original Issue

 BEFORE|AFTER
 ---|---
(None) | For CAVC Lit Support Admin user for an org-task ![image](https://user-images.githubusercontent.com/55255674/98159593-7ae07e00-1ea2-11eb-9d8c-f2db5816b56b.png)
(None) | For CAVC Lit Support Non-Admin user for a user-task ![image](https://user-images.githubusercontent.com/55255674/98589425-dfc91900-2292-11eb-8786-d6c2ff87a6fc.png)

### Code Documentation Updates
- [x] Add or update code comments at the top of the class, module, and/or component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoomlam yoomlam

Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: New Development New feature development
Projects
No open projects
Team Echo
Done
Milestone
PI5-S7: Veterans Day Sprint
Development

Successfully merging a pull request may close this issue.

Add SendCavcRemandProcessedLetterTask department-of-veterans-affairs/caseflow
4 participants
@hschallhorn @yoomlam @araposo-tistatech @mbaenatan