Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit EP Claim Labels | Add End Product Update model #15330

Closed
17 tasks done
leikkisa opened this issue Sep 28, 2020 · 0 comments
Closed
17 tasks done

Edit EP Claim Labels | Add End Product Update model #15330

leikkisa opened this issue Sep 28, 2020 · 0 comments
Assignees
@Sjones352
Labels
Product: caseflow-intake Stakeholder: VBA Functionality associated with Veterans Benefits Administration workflows/feature requests Team: Foxtrot 🦊 User: VBA Intake
Milestone
PI5-S5: Eleanor R...

Comments

@leikkisa
Copy link
Contributor

leikkisa commented Sep 28, 2020 •
edited by Sjones352

Description

Add a model for End Product updates to keep track of the requests to update the claim label, and use as a container for handling the data changes.

Acceptance criteria

  • DB migration to add EndProductUpdate
    • Timestamps
    • User ID
    • EndProductEstablishment ID
    • Original code
    • New code
    • Original decision review ID (null values allowed)
    • Original decision review type (null values allowed)
    • Status (success/error) (null values allowed)
    • Error (null values allowed)
    • IDs of active request issues on the end product establishment
    • Index by updated_at
  • Create an EndProductUpdate model (can mostly be an empty container)
    • define Rails association that it belongs to EndProductEstablishment, and that EndProductEstablishment has many of these
    • define Rails association for the original_decision_review
    • Enum status to include success or error
  • Add EndProductUpdate factory for specs (optional)

Open questions

  • The decision review type can't change, but does it make sense to also store it on here?
    • Answered during review, let's go ahead and add it.

Background/context/resources

Technical notes
@leikkisa leikkisa added Product: caseflow-intake Stakeholder: VBA Functionality associated with Veterans Benefits Administration workflows/feature requests Team: Foxtrot 🦊 User: VBA Intake labels Sep 28, 2020
@leikkisa leikkisa changed the title Edit EP Claim Labels | Add End Product Establishment Update model Edit EP Claim Labels | Add End Product Update model Sep 28, 2020
@Sjones352 Sjones352 self-assigned this Oct 2, 2020
@Theresa1976 Theresa1976 mentioned this issue Oct 5, 2020
Closed
@Sjones352 Sjones352 mentioned this issue Oct 6, 2020
Merged
18 tasks
va-bot pushed a commit that referenced this issue Oct 8, 2020
@Sjones352
Edit EP Claim Labels | Add End Product Update model (#15383)
b35e926 
Connects  #15330

### Description
This pr adds a new End Product Update table and model

### Acceptance Criteria
- [ ] DB migration to add EndProductUpdate
  - [ ] Timestamps
  - [ ] User ID
  - [ ] EndProductEstablishment ID
  - [ ] Original code
  - [ ] New code
  - [ ] Original decision review ID
  - [ ] Status (success/error)
  - [ ] Error
  - [ ] IDs of active request issues on the end product establishment

### Database Changes
*Only for Schema Changes*

* [x] Timestamps (created_at, updated_at) for new tables
* [x] Column comments updated
* [x] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`)
* [x] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method))
* [ ] Query profiling performed (eyeball Rails log, check bullet and fasterer output)
* [x] Appropriate indexes added (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
* [x] DB schema docs updated with `make docs` (after running `make migrate`)
* [x] #appeals-schema notified with summary and link to this PR
@Sjones352 Sjones352 mentioned this issue Oct 8, 2020
Merged
5 tasks
@leikkisa leikkisa closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sjones352 Sjones352

Labels
Product: caseflow-intake Stakeholder: VBA Functionality associated with Veterans Benefits Administration workflows/feature requests Team: Foxtrot 🦊 User: VBA Intake
Projects
None yet
Milestone
PI5-S5: Eleanor Roosevelt Sprint
Development

No branches or pull requests
2 participants
@leikkisa @Sjones352