Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create RO Picker Design to replace Caseflow login screen #2272

Closed
NickHeiner opened this issue Jun 7, 2017 · 7 comments
Closed

Create RO Picker Design to replace Caseflow login screen #2272

NickHeiner opened this issue Jun 7, 2017 · 7 comments
Assignees

Comments

@NickHeiner
Copy link
Contributor

NickHeiner commented Jun 7, 2017

Ticket cloned from https://github.com/department-of-veterans-affairs/appeals-design-research/issues/248.

Context

VACOLS is moving to 2 factor authentication on June 10th (earliest) or mid-July. When this happens, users at ROs that have more than 1 VACOLS RO ID to their 1 VBMS Station ID will not be able to access Caseflow. Caseflow login screen currently tries to use their VACOLS login to log into VACOLS. But with 2FA we will be prevented from doing that. 😱

AC

  • Verify that after use login with VBMS ID, the dropdown is populated with the corresponding VACOLS RO IDs
  • Welcome message is in h1 and instruction is in lead paragraph Style guide text styling
  • Style guide dropdown component with "Select office..." inside the dropdown
  • Dropdown options format should be "RO Name, State - RO ID"
  • Verify button below says "Login"
  • Verify that once this is deployed to UAT, eFolder still works
  • Verify that a user with multiple ROs for their station ID can log in
  • Verify that a user with one RO for their station ID can log in

Mock up

image

image

Copy

Welcome to Caseflow!
Please select the Regional Office site you are logging in from

Reference

List of VBMS Station IDs and VACOLS RO IDs:
https://github.com/department-of-veterans-affairs/caseflow/blob/master/app/models/vacols/regional_office.rb

@NickHeiner NickHeiner self-assigned this Jun 7, 2017
@NickHeiner
Copy link
Contributor Author

@gnakm what should the error state be if the server has an error when the user clicks the "login" button?

@gnakm
Copy link

gnakm commented Jun 7, 2017

@NickHeiner Great question! I was just about to ask you what are the potential errors in this situation.

I have this generic one. If you can tell me more in detail what is happening in the backend, that would be helpful. Other wise, if this works please give it a thumbs up and I will add it to the AC above.

image

AC

  • Verify copy matches below:
    Title: Technical Difficulties
    Body copy:
    It looks like Caseflow is experiencing technical difficulties right now. (linebreak)
    Please refresh the page and try again.
  • Use Message Style guide component
  • Refresh the page should be a link that allows users to refresh the page

🥃 📋

@gnakm
Copy link

gnakm commented Jun 7, 2017

@NickHeiner Let me know if you want ^^the above to be a separate issue.

@NickHeiner
Copy link
Contributor Author

Nah, I'll do it in this PR. Thanks!

@NickHeiner
Copy link
Contributor Author

If you can tell me more in detail what is happening in the backend, that would be helpful.

I don't think that a more specific error message is needed.

NickHeiner added a commit that referenced this issue Jun 9, 2017
Now that VACOLS is going to 2FA, we shouldn't be using VACOLS credentials to disambiguate the which RO the user is in.

Connect #2272.
@ghost ghost removed the In Progress label Jun 9, 2017
@ghost
Copy link

ghost commented Jun 10, 2017

PASSED

Started GET "/functions" for 127.0.0.1 at 2017-06-09 20:20:19 -0400                                                                                                                                             dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-07ff971c8316a87b6-172.30.71.34 [appeals.cf.uat.ds.va.gov] [d98edfb4-0d5d-476e-b18d-e34e914abc96] [172.30.71.34] [CF_MCCOY_283   caseflow@va.gov] [2017-06-09 20:20:19 -0400] 
Processing by FunctionsController#index as HTML                                                                                                                                                                 
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-07ff971c8316a87b6-172.30.71.34 [appeals.cf.uat.ds.va.gov] [d98edfb4-0d5d-476e-b18d-e34e914abc96] [172.30.71.34] [CF_MCCOY_283   caseflow@va.gov] [2017-06-09 20:20:19 -0400]   User Load (1.3ms)  SELECT  "users".* FROM "users" WHERE "users"."css_id" = $1 AND "users"."station_id" = $2 LIMIT 1  [["css_id", "CF_MCCOY_283"], ["station_id", "283"]]                                      
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-07ff971c8316a87b6-172.30.71.34 [appeals.cf.uat.ds.va.gov] [d98edfb4-0d5d-476e-b18d-e34e914abc96] [172.30.71.34] [CF_MCCOY_283   caseflow@va.gov] [2017-06-09 20:20:19 -0400]    (1.0ms)  BEGIN                                                                                                                                                                                               
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-07ff971c8316a87b6-172.30.71.34 [appeals.cf.uat.ds.va.gov] [d98edfb4-0d5d-476e-b18d-e34e914abc96] [172.30.71.34] [CF_MCCOY_283   caseflow@va.gov] [2017-06-09 20:20:19 -0400]    (1.0ms)  COMMIT                                                                                                                                                                                              
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-07ff971c8316a87b6-172.30.71.34 [appeals.cf.uat.ds.va.gov] [d98edfb4-0d5d-476e-b18d-e34e914abc96] [172.30.71.34] [CF_MCCOY_283   caseflow@va.gov] [2017-06-09 20:20:20 -0400] Redirected to https://appeals.cf.uat.ds.va.gov/login                                                                                                                                                            
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-07ff971c8316a87b6-172.30.71.34 [appeals.cf.uat.ds.va.gov] [d98edfb4-0d5d-476e-b18d-e34e914abc96] [172.30.71.34] [CF_MCCOY_283   caseflow@va.gov] [2017-06-09 20:20:20 -0400] Filter chain halted as :verify_authentication rendered or redirected

dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-07ff971c8316a87b6-172.30.71.34 [appeals.cf.uat.ds.va.gov] [d98edfb4-0d5d-476e-b18d-e34e914abc96] [172.30.71.34] [CF_MCCOY_283   caseflow@va.gov] [2017-06-09 20:20:20 -0400] 
Completed 302 Found in 26ms (ActiveRecord: 10.2ms)                                                                                                                                                              
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-07ff971c8316a87b6-172.30.71.34 172.30.69.231, 172.30.70.242 - - [09/Jun/2017:20:20:20 -0400] "GET /functions HTTP/1.0" 302 - 0.0303            
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-07ff971c8316a87b6-172.30.71.34 [2017-06-09 20:20:20 -0400] Puma stats -- Process pid: 2832 Total threads: 64 Backlog of actions: 0 Waiting threads: 64 Active threads: 0 Live threads: 64/64 alive                                                                                                                                                                                           
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-0c341081c093b5acd-172.30.67.171 [2017-06-09 20:20:21 -0400] Puma stats -- Process pid: 2749 Total threads: 64 Backlog of actions: 0 Waiting threads: 64 Active threads: 0 Live threads: 64/64 alive                                                                                                                                                                                          
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-07ff971c8316a87b6-172.30.71.34 172.30.66.175 - dsva [09/Jun/2017:20:20:22 -0400] "GET /metrics HTTP/1.0" 200 - 0.0109                          
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-0c341081c093b5acd-172.30.67.171 172.30.66.175 - dsva [09/Jun/2017:20:20:22 -0400] "GET /metrics HTTP/1.0" 200 - 0.0280                         
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-0c341081c093b5acd-172.30.67.171 [appeals.cf.uat.ds.va.gov] [5f0e49b7-7c69-4bc9-9f89-57ee0f7afcd0] [172.30.67.171] [CF_MCCOY_283   caseflow@va.gov] [2017-06-09 20:20:24 -0400] Started PATCH "/sessions/update" for 127.0.0.1 at 2017-06-09 20:20:24 -0400                                                                                                                                   
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-0c341081c093b5acd-172.30.67.171 [appeals.cf.uat.ds.va.gov] [5f0e49b7-7c69-4bc9-9f89-57ee0f7afcd0] [172.30.67.171] [CF_MCCOY_283   caseflow@va.gov] [2017-06-09 20:20:24 -0400] Processing by SessionsController#update as JSON                                                                                                                                                               
dsva-appeals-certification-uat/opt/caseflow-certification/src/log/caseflow-certification.out i-0c341081c093b5acd-172.30.67.171 [appeals.cf.uat.ds.va.gov] [5f0e49b7-7c69-4bc9-9f89-57ee0f7afcd0] [172.30.67.171] [CF_MCCOY_283   caseflow@va.gov] [2017-06-09 20:20:24 -0400]   
Parameters: {"regional_office"=>"RO97", "id"=>"update", "session"=>{"regional_office"=>"RO97"}}

@ghost
Copy link

ghost commented Jun 10, 2017

PASSED
multiro

@ghost ghost closed this as completed Jun 10, 2017
@ghost ghost removed the In Validation label Jun 10, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants