Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document List | Search state persists across different cases #3451

Closed
3 of 4 tasks
ghost opened this issue Sep 28, 2017 · 8 comments
Closed
3 of 4 tasks

Document List | Search state persists across different cases #3451

ghost opened this issue Sep 28, 2017 · 8 comments

Comments

@ghost
Copy link

ghost commented Sep 28, 2017

Description

When applying filters/search to one Document List,
it seems like the state of the filtering/search persists across all document lists.

Reproduction Steps

Scenario 1 -

  1. Go to one case and enter a search string
  2. Or filter by category
  3. Go to another case
  4. See that you're still in the searching/fitlering state

Validated in the following Environment(s)

  • Dev
  • UAT
  • Preprod
  • Prod

Screenshots

Scenario 1 - [Not the docs you're looking for]
still_looking

@ghost
Copy link
Author

ghost commented Oct 24, 2017

Filtered state persists:

filterstate

@ghost
Copy link
Author

ghost commented Oct 26, 2017

Filtered state persists across Cases:

filtered

Searched state gets cleared after viewing a document within a case. Intended?

samecasesearch

YA DIDN'T MERGE THE PR BRUH WHY IS IT HERE?!?! 😄

@ghost ghost added In-Progress and removed In-Validation labels Oct 26, 2017
@dannysellers
Copy link
Contributor

😧 I don't get the first behavior, and the second (in-document text search) isn't part of this ticket—this is just about searching from the claims folder page. The text search isn't finished yet (clearly)

out

@ghost
Copy link
Author

ghost commented Oct 26, 2017

screen shot 2017-10-26 at 5 49 00 pm

  • I think you didn't merge your PR yet.
  • Once it's merged to master it gets deployed to UAT/Preprod and that's when I can test it
  • In UAT/Preprod the app is deployed in production mode as is hooked up to all the VA backends.
  • That's when the Github issue can go into In-Validation
  • I don't test anything locally or with fakes. That's for whoever reviews your PR (not me)

@dannysellers
Copy link
Contributor

Ugh, I definitely knew that, at least implicitly... Thanks for spelling it out—I'll let you know when this has been reviewed/merged

@ghost
Copy link
Author

ghost commented Oct 27, 2017

All good :D

@dannysellers dannysellers unassigned ghost Oct 27, 2017
@ghost ghost self-assigned this Oct 27, 2017
@ghost
Copy link
Author

ghost commented Oct 30, 2017

Now it's back to persisting :( on all cases

  • Open Document List
  • Enter a search token
  • Observe filtering take effect
  • Go back to Welcome Gate
  • Go to another Document List
  • observe that results are still filtered

isaidhey_whatsgoingon

@dannysellers
Copy link
Contributor

It looks like the clearSearch and clearAllFilters actions were relocated after this was merged, so it doesn't work any more. PR #3789 addresses this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants