Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy/paste the Vet ID button style #4334

Closed
lakohl opened this issue Jan 10, 2018 · 10 comments
Closed

Update copy/paste the Vet ID button style #4334

lakohl opened this issue Jan 10, 2018 · 10 comments
Assignees
Labels
Project: design-style-guide Used by the design team to track work directly related to or impacting the style guide Team: Tango 💃

Comments

@lakohl
Copy link
Contributor

lakohl commented Jan 10, 2018

Update the copy/paste interaction of the Vet ID button.

AC

Let the user know what the Vet ID button does.

  1. On hover, display the following tool tip message: [Copy Veteran ID] in 19px type.
  2. Show the Vet ID button in its gray-dark hover state.
  3. On click, display the following snackbar message: [Veteran ID copied to clipboard.] in 19px type, for 1600ms.

Mock
2018-02-12 14 03 31

@lakohl lakohl self-assigned this Jan 10, 2018
@lakohl lakohl added Backlog Project: design-style-guide Used by the design team to track work directly related to or impacting the style guide Team: Tango 💃 labels Jan 10, 2018
@annienguyenUSDS
Copy link

Checking if this was already updated?

@lakohl
Copy link
Contributor Author

lakohl commented Jan 19, 2018

The old (styleguide) version of this button is currently live in HP. This Design Issue exists to update the styling: https://github.com/department-of-veterans-affairs/appeals-design-research/issues/632

@lakohl
Copy link
Contributor Author

lakohl commented Feb 8, 2018

Possible approach
2018-01-05 12 52 04
The InVision Public Share link first provides a tooltip on hover 'Copy to clipboard', then displays a toast with the feedback 'Copied to Clipboard'.

@lakohl
Copy link
Contributor Author

lakohl commented Feb 12, 2018

OPTIONS @annienguyenUSDS

Tooltips:

tooltip stem

tooltip no stem space

tooltip little space

Snackbars:

  1. top green:
    alert lt

  2. Floating version of snackbar:
    floating green

  3. Dark version of snackbar message.
    alert dark

  4. Floating dark version of snackbar message.
    alert dark low

@lakohl
Copy link
Contributor Author

lakohl commented Feb 12, 2018

Invision interaction:
https://va-gov.invisionapp.com/share/JWFT6H8R7HC

@lakohl
Copy link
Contributor Author

lakohl commented Feb 12, 2018

2018-02-12 14 03 31

@Sjones352
Copy link
Contributor

@lakohl dropping [Copy Veteran ID] in 19px type to 13px is like screenshot below. I think we should drop it further down to may 10px.
screen shot 2018-05-22 at 8 39 05 pm

@lakohl
Copy link
Contributor Author

lakohl commented May 30, 2018

@Sjones352 seeing as we can only have one string of copy for both hover and click, please use this text: 'Click to copy to Clipboard'

@Sjones352
Copy link
Contributor

@lakohl that's at 19px
screen shot 2018-05-30 at 7 27 32 pm

And this is at 13px
screen shot 2018-05-30 at 7 29 54 pm

@lakohl
Copy link
Contributor Author

lakohl commented May 31, 2018

@Sjones352 Let's go with 14px Source Sans bold. My apologies for causing confusion, 'clipboard' should start with a lowercase c.

Sjones352 added a commit that referenced this issue Jun 7, 2018
HP Refactor copy button (#4334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: design-style-guide Used by the design team to track work directly related to or impacting the style guide Team: Tango 💃
Projects
None yet
Development

No branches or pull requests

5 participants