Create subclass for JudgeTasks created by Quality Review #8107
Assignees
Comments
|
If we are able to come up with a satisfactory workaround for changing a task's status manually (maybe through the database directly?) without triggering a cascade of changes to parent tasks, we should consider moving the |
va-bot
pushed a commit
that referenced
this issue
Dec 5, 2018
This was referenced Dec 17, 2018
va-bot
pushed a commit
that referenced
this issue
Dec 21, 2018
When the Quality Review team returns a case to a judge we create a `JudgeAssignTask`. If a `JudgeAssignTask` has a parent task of the type `QualityReviewTask` then we display an option to "Mark task complete" in order to return the case to the Quality Review team after the judge has addressed the concerns of the Quality Review team. However, if the judge assigns one of these cases to an attorney on their team (in the parlance of the application, creates a child `AttorneyTask`) then we change the type of the judge task from `JudgeAssignTask` to `JudgeReviewTask` [after the attorney returns the case to the judge](https://github.com/department-of-veterans-affairs/caseflow/blob/53dc4c07c63e195130d6ad9973a9515871bf1941/app/models/tasks/judge_task.rb#L23) (completes the `AttorneyTask`). Because we change the type of task, we no longer display the "Mark task complete" option. This PR changes that to correctly display the "Mark task complete" option in those cases. This is just a temporary bugfix that should be addressed in a more thorough way by #8107.
ghost
added
the
tomas-nava
pushed a commit
that referenced
this issue
Jan 2, 2019
This is a new subclass for JudgeTasks created by Quality Review. Connects #8107
tomas-nava
pushed a commit
that referenced
this issue
Jan 2, 2019
- parent status set to on_hold in before_create hook - move methods from JudgeTask into children - remove `modify_params` - use javascript include method - override available_actions Connects #8107
tomas-nava
pushed a commit
that referenced
this issue
Jan 2, 2019
tomas-nava
pushed a commit
that referenced
this issue
Jan 2, 2019
va-bot
pushed a commit
that referenced
this issue
Jan 2, 2019
This is a new subclass for JudgeTasks created by Quality Review. Also renames `JudgeReviewTask` to `JudgeDecisionReviewTask` Connects #8107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
JudgeAssignTasks can be created when cases are distributed to judges or when the Quality Review team returns a task to the signing judge.JudgeAssignTaskandJudgeReviewTask, so we can follow their lead and create another subclass to encapsulate the quality review-related logic we added in Add option to complete JudgeTasks created by Quality Review #8106.Acceptance criteria
JudgeQualityReviewTaskthat encapsulates quality review-related logicJudgeQualityReviewTasks show up in judge review tableJudgeReviewTasktoJudgeDecisionReviewTaskJudgeReviewTasks toJudgeDecisionReviewTasksThe text was updated successfully, but these errors were encountered: