Re-enable table filter names for org queues #11239
Conversation
| @@ -109,6 +112,7 @@ class OrganizationQueue extends React.PureComponent { | |||
| numberOfPages={tabConfig.task_page_count} | |||
| totalTaskCount={tabConfig.total_task_count} | |||
| taskPagesApiEndpoint={tabConfig.task_page_endpoint_base_path} | |||
| alternateColumnNames={COLUMN_NAMES} | |||
There was a problem hiding this comment.
Heart of the change here.
client/app/queue/constants.js
Outdated
| @@ -170,7 +170,8 @@ export const COLOCATED_HOLD_DURATIONS = [15, 30, 45, 60, 90, 120, CUSTOM_HOLD_DU | |||
|
|
|||
| export const COLUMN_NAMES = { | |||
| 'appeal.caseType': 'Case Type', | |||
| 'appeal.docketName': 'Docket Number', | |||
| 'appeal.docketName': COPY.CASE_LIST_TABLE_DOCKET_NUMBER_COLUMN_TITLE, | |||
| 'assignedTo.name': COPY.CASE_LIST_TABLE_APPEAL_LOCATION_COLUMN_TITLE, | |||
There was a problem hiding this comment.
Adds this alternative column name that was missing before.
client/app/queue/constants.js
Outdated
| @@ -170,7 +170,8 @@ export const COLOCATED_HOLD_DURATIONS = [15, 30, 45, 60, 90, 120, CUSTOM_HOLD_DU | |||
|
|
|||
| export const COLUMN_NAMES = { | |||
| 'appeal.caseType': 'Case Type', | |||
| 'appeal.docketName': 'Docket Number', | |||
| 'appeal.docketName': COPY.CASE_LIST_TABLE_DOCKET_NUMBER_COLUMN_TITLE, | |||
There was a problem hiding this comment.
Changes the text here from "Docket Number" to "Docket" since that is really what we are filtering on (legacy, hearing, evidence, direct).
|
Code Climate has analyzed commit 1feba1b and detected 0 issues on this pull request. View more on Code Climate. |
|
Looks like both (and only) places where we implement |
lowellrex
added
the
Ready-to-Merge
The move from using the
TaskTablecomponent to using theQueueTablecomponent in PR #11213 left behind our friendly names that we display when we are filtering columns in that table. This PR adds those back in.There is probably a longer-term fix here to just use the column's
headerattribute as defined inTaskTable, but a quick glance at the code makes it appear as if that will be a fairly involved change.