Allow QueueTab to return tasks #11735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowellrex
commented
Aug 12, 2019
|
Code Climate has analyzed commit e497384 and detected 0 issues on this pull request. View more on Code Climate. |
lowellrex
commented
Aug 12, 2019
app/models/task_pager.rb
Outdated
| else | ||
| fail(Caseflow::Error::InvalidTaskTableTab, tab_name: tab_name) | ||
| end | ||
| QueueTab.from_name(tab_name).new(assignee: organization).tasks |
There was a problem hiding this comment.
The rest of the changes spring from this one.
hschallhorn
approved these changes
Aug 12, 2019
lowellrex
added
the
Ready-to-Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects #11733. Moves logic for fetching tasks for a given tab from
TaskPagerto each individualQueueTab.Three major changes included in this PR:
TaskPagerno longer controls which tasks a given tab is supposed to return. That responsibility is transferred to the variousQueueTabsubclasses'tasksmethod.QueueTabs now require anassigneeargument when they are created.QueueTab.from_namefunction for returning a tab class given the tab's name string we receive from the front-end.