Remove use_task_pages_api feature toggle now that all users have it enabled #12744
Conversation
| @@ -141,38 +141,33 @@ def fill_in_and_submit_bulk_assign_modal | |||
| end | |||
| end | |||
|
|
|||
| context "when tasks in queue are paginated" do | |||
There was a problem hiding this comment.
best to view these changes ignoring whitespace!
| @@ -16,14 +16,14 @@ def initialize(args) | |||
| end | |||
| end | |||
|
|
|||
| def to_hash_for_user(user) | |||
| def to_hash | |||
There was a problem hiding this comment.
user was only used to ensure this user had use_task_pages_api turned on, so it is removed essentially everywhere.
|
Code Climate has analyzed commit cfd6382 and detected 0 issues on this pull request. View more on Code Climate. |
| @@ -20,19 +20,11 @@ def tasks | |||
| return [] if queue_config[:use_task_pages_api] | |||
|
|
|||
| Rails.logger.debug("starting GenericQueue tasks") | |||
|
|
|||
| # Temporarily limit hearings-management tasks to AOD tasks, because currently no tasks are loading | |||
| if organization.url == "hearings-management" | |||
There was a problem hiding this comment.
HearingsManagement and all users have pagination enabled, should never reach this code
There was a problem hiding this comment.
Does this mean that all Caseflow users ( HearingsManagement and all others) will always return [] because queue_config[:use_task_pages_api] will always be true?
There was a problem hiding this comment.
use_task_pages_api will be false for all orgs other than the select few where .use_task_pages_api? is defined as true
There was a problem hiding this comment.
Ah yes, you are right. Thanks!
| .includes(*task_includes) | ||
| .order(created_at: :asc) | ||
| .limit(limit) | ||
| end | ||
|
|
||
| def relevant_appeal_types |
There was a problem hiding this comment.
Vsos and all users have pagination enabled, should never reach this code
| @@ -35,10 +35,6 @@ def tracking_tasks_tab | |||
| ::OrganizationTrackingTasksTab.new(assignee: self) | |||
| end | |||
|
|
|||
| def ama_task_serializer | |||
There was a problem hiding this comment.
Vsos and all users have pagination enabled, should never reach this code
| @@ -224,8 +224,10 @@ | |||
| let(:tracking_task_count) { 14 } | |||
|
|
|||
| before do | |||
| create_list(:informal_hearing_presentation_task, unassigned_count, :in_progress, assigned_to: vso) | |||
| create_list(:informal_hearing_presentation_task, assigned_count, :on_hold, assigned_to: vso) | |||
| create_list(:informal_hearing_presentation_task, unassigned_count, assigned_to: vso) | |||
There was a problem hiding this comment.
Why remove the task status settings here?
There was a problem hiding this comment.
Wasn't really necessary. Creating a task will make the task active and creating a child will put the task on hold.
hschallhorn
added
the
Ready-to-Merge
Resolves #12216, Resolves #12781.
Description
Removes all mention of the
use_task_pages_apias it has been enabled for all users since #2224Acceptance Criteria
use_task_pages_apifeature toggle is removed