Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old style hold code #12956

Merged
merged 13 commits into from Dec 13, 2019
Merged

Remove old style hold code #12956

merged 13 commits into from Dec 13, 2019

Conversation

hschallhorn
Copy link
Contributor

@hschallhorn hschallhorn commented Dec 12, 2019 •
edited by lomky

References #10896
Resolves #11658

Description

Removes all code that references the old way of setting tasks on hold. Migration PR will happen separately.

Acceptance Criteria

  • Old style hold code is removed
  • Task factory is updated to use new style of "on hold"

@hschallhorn hschallhorn self-assigned this Dec 12, 2019
@codeclimate
Copy link

codeclimate bot commented Dec 12, 2019 •
edited

Code Climate has analyzed commit 254ff4f and detected 0 issues on this pull request.

View more on Code Climate.

@va-bot
Copy link
Collaborator

va-bot commented Dec 12, 2019

1 Warning
⚠️ This is a Big PR. Try to break this down if possible.

Generated by 🚫 Danger

lomky
lomky approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@lomky lomky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job tracking it all down 🕵️‍♀️ GTG once circle is passing

@hschallhorn hschallhorn added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Dec 13, 2019
@hschallhorn hschallhorn merged commit 2d7f9ae into master Dec 13, 2019
@hschallhorn hschallhorn deleted the hschallhorn/10896-auf-wiedersehen-old-style-holds branch December 13, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lomky lomky lomky approved these changes

Assignees

@hschallhorn hschallhorn

Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update task factory on_hold traits
3 participants
@hschallhorn @va-bot @lomky