-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric: Certifications via Caseflow #13367
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarman
commented
Feb 6, 2020
@certified_with_caseflow ||= certifications.select(&:certified_with_caseflow?).count | ||
end | ||
|
||
def regional_office_codes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBD whether this is needed or not
Code Climate has analyzed commit ab1a2ac and detected 0 issues on this pull request. View more on Code Climate. |
pkarman
commented
Feb 6, 2020
folder.tivbms == "Y" | ||
end | ||
|
||
def certified_with_caseflow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alisan16
reviewed
Feb 10, 2020
pkarman
force-pushed
the
pek-certifications-metric
branch
from
February 10, 2020 15:57
d1690e5
to
d5b5278
Compare
alisan16
approved these changes
Feb 10, 2020
pkarman
added
the
Ready-to-Merge
This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
label
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ready-to-Merge
This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects #12554
Description
OIT metric for Certifications via Caseflow.
Testing Plan
Documentation Updates