Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric: Certifications via Caseflow #13367

Merged
merged 6 commits into from
Feb 10, 2020
Merged

Metric: Certifications via Caseflow #13367

merged 6 commits into from
Feb 10, 2020

Conversation

pkarman
Copy link
Contributor

@pkarman pkarman commented Feb 6, 2020

connects #12554

Description

OIT metric for Certifications via Caseflow.

Testing Plan

  1. Monkeypatch and run in production console for verifying logic.

Documentation Updates

  • Topline File Descriptions Added or Updated as Needed

@pkarman pkarman self-assigned this Feb 6, 2020
@certified_with_caseflow ||= certifications.select(&:certified_with_caseflow?).count
end

def regional_office_codes
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBD whether this is needed or not

@codeclimate
Copy link

codeclimate bot commented Feb 6, 2020

Code Climate has analyzed commit ab1a2ac and detected 0 issues on this pull request.

View more on Code Climate.

folder.tivbms == "Y"
end

def certified_with_caseflow?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkarman pkarman requested a review from alisan16 February 7, 2020 19:16
@pkarman pkarman added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Feb 10, 2020
@va-bot va-bot merged commit 840e104 into master Feb 10, 2020
@va-bot va-bot deleted the pek-certifications-metric branch February 10, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants