Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logic for displaying virtual hearing type #13832

Merged
merged 25 commits into from Jul 31, 2020
Merged

Update logic for displaying virtual hearing type #13832

merged 25 commits into from Jul 31, 2020

Conversation

ferristseng
Copy link
Contributor

@ferristseng ferristseng commented Mar 31, 2020 •
edited

Resolves #14787

Description

  • Updates how the query that populates the hearing type works
  • Fix to the seed script to properly label legacy central hearings
  • Expand tests for HearingDayRequestTypeQuery to cover central hearings that were converted to virtual
  • Add story for DailyDocketPrinted

Acceptance Criteria

  • Hearing schedule table Type column updated
  • Daily Docket Hearing type updated
  • Printable Daily Docket Hearing type updated
  • Printable Daily Docket row Type: Virtual updated

Screenshots

Daily Docket Header

Screen Shot 2020-07-29 at 2 30 10 PM

Daily Docket Row

Screen Shot 2020-07-29 at 2 30 17 PM

Daily Docket Printed

Screen Shot 2020-07-29 at 2 30 42 PM

Hearing Schedule

Screen Shot 2020-07-29 at 2 30 56 PM

@va-bot
Copy link
Collaborator

va-bot commented Mar 31, 2020 •
edited

2 Warnings
⚠️ This is a Big PR. Try to break this down if possible. Stacked pull requests encourage more detailed and thorough code reviews
⚠️ This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger

@codeclimate
Copy link

codeclimate bot commented Mar 31, 2020 •
edited

Code Climate has analyzed commit 8355550 and detected 0 issues on this pull request.

View more on Code Climate.

@chandracarney chandracarney mentioned this pull request May 27, 2020
Closed
2 tasks
@ferristseng ferristseng changed the title [WIP] Convert central hearing to virtual [WIP] Update logic to display virtual hearing type Jul 28, 2020
@ferristseng ferristseng changed the title [WIP] Update logic to display virtual hearing type [WIP] Update logic for displaying virtual hearing type Jul 28, 2020
@ferristseng ferristseng changed the title [WIP] Update logic for displaying virtual hearing type Update logic for displaying virtual hearing type Jul 29, 2020
@ferristseng ferristseng requested review from a team and rubaiyat22 and removed request for a team July 29, 2020 18:39
rubaiyat22
rubaiyat22 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@rubaiyat22 rubaiyat22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great!

just wanted to bring to your attention something that i've been noticing in dev where there are virtual type under central hearing days but i think this might a dev issue only
Screen Shot 2020-07-31 at 10 17 46 AM

client/app/hearings/components/dailyDocket/DailyDocketPrinted.jsx
hearings: PropTypes.object,

// Whether or not to display the print screen prompt.
disablePrompt: PropTypes.bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added so that the storybook component does not open print page

spec/queries/hearing_day_request_type_query_spec.rb
@@ -1,27 +1,21 @@
# frozen_string_literal: true

describe VideoHearingDayRequestTypeQuery do
subject { VideoHearingDayRequestTypeQuery.new.call }
describe HearingDayRequestTypeQuery do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through the test and noticed that this test and this test is expecting the type for previously virtual hearings to be Virtual. If a virtual hearing is cancelled, shouldn't the type be it's original type i.e video or central?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think you're right about that, but I think those 2 tests setup an active and a cancelled virtual hearing, and are confirming that the cancelled one doesn't affect the result.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Okay makes sense! Thanks for clarifying!

@ferristseng
Copy link
Contributor Author

just wanted to bring to your attention something that i've been noticing in dev where there are virtual type under central hearing days but i think this might a dev issue only

Yep, I was seeing this too. The change to the seeds file should fix that issue 🤞

@ferristseng ferristseng added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Jul 31, 2020
@va-bot va-bot merged commit 30035f6 into master Jul 31, 2020
@va-bot va-bot deleted the ftseng-convert-central-to-virtual branch July 31, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubaiyat22 rubaiyat22 rubaiyat22 approved these changes

Assignees
No one assigned
Labels
Feature: hearings-schedule Product: caseflow-hearings Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master Team: Tango 💃
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hearing type should show "Central, Virtual"
3 participants
@ferristseng @va-bot @rubaiyat22