Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Paginate attorney queues #14426

Conversation

hschallhorn
Copy link
Contributor

Bumps #14142

Description

Please explain the changes you made here.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to ...

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Storybook Story

For Frontend (Presentationa) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

Database Changes

Only for Schema Changes

  • Timestamps (created_at, updated_at) for new tables
  • Column comments updated
  • Query profiling performed (eyeball Rails log, check bullet and fasterer output)
  • Appropriate indexes added (especially for foreign keys, polymorphic columns, and unique constraints)
  • DB schema docs updated with make docs
  • #appeals-schema notified with summary and link to this PR

@hschallhorn hschallhorn self-assigned this May 29, 2020
@hschallhorn hschallhorn marked this pull request as draft May 29, 2020 14:55
@va-bot
Copy link
Collaborator

va-bot commented May 29, 2020

2 Warnings
⚠️ PR is classed as Work in Progress
⚠️ This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger

@codeclimate
Copy link

codeclimate bot commented May 29, 2020

Code Climate has analyzed commit 98aa2e7 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

View more on Code Climate.

@hschallhorn
Copy link
Contributor Author

Closing to stack!

@hschallhorn hschallhorn deleted the hschallhorn/14142-paginate-all-but-assigned-attorney-tab branch July 10, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants