Improve Performance of Daily Docket Page

[ferristseng]

Resolves #14432

Description

Performance Improvements:

• Update LegacyHearing#quick_to_hash to actually call the quick hasher
• Load POA details async on Daily Docket. This allows us to skip hashing it on the backend (avoiding a call to BGS), and hide the Caseflow-loading-logo more quickly
• For quick hasher, remove email addresses, email events, and representative info. Those can all trigger BGS calls
• Prevent DailyDocketContainer from loading hearings twice. Hearings are returned with the hearing day, but also the full details are async loaded. This removes fetching each individual hearing async.

I mainly tried to focus on trying to reduce unnecessary calls to BGS. New Relic was showing that the bulk of processing time was spent waiting for BGS (top 2 categories):

I removed calls to fetch associated data that we didn't need on the daily docket page, especially data that could trigger a call to BGS like email address data. One thing I couldn't do was remove the BGS call to get representative details, but we did have components that could load it async, which I ended up using to make it appear the page was loading a bit faster.

Benchmarks

Before

#---#
2020-03-12 ID: 4644
2020-06-23 ID: 5499

Benchmark.measure do
  HearingDay.find(4644)
    .hearings_for_user(User.system_user)
    .map { |h| h.quick_to_hash(1217) }
end
#---#

4644 => #<Benchmark::Tms:0x000000000ed580c8 @label="", @real=43.06742242600012, @cstime=0.0, @cutime=0.0, @stime=0.15835700000000008, @utime=1.6796589999999991, @total=1.8380159999999992>

5499 => #<Benchmark::Tms:0x000000000f00bb58 @label="", @real=30.49937072099965, @cstime=0.0, @cutime=0.0, @stime=0.15402099999999996, @utime=1.3248880000000005, @total=1.4789090000000005>

After

#---#
2020-03-12 ID: 4644
2020-06-23 ID: 5499

Benchmark.measure do
  HearingDay.find(4644)
    .hearings_for_user(User.system_user)
    .map do |h|
      if h.is_a?(LegacyHearing)
        ::LegacyHearingSerializer.quick(
          h,
          params: { current_user_id: User.system_user.id }
        ).serializable_hash[:data][:attributes]
      else
        h.quick_to_hash(1217)
      end
    end
end
#---#

4644 => #<Benchmark::Tms:0x000000000e64b960 @label="", @real=3.9002713530007895, @cstime=0.0, @cutime=0.0, @stime=0.04220700000000033, @utime=0.4883059999999997, @total=0.530513>

5499 => #<Benchmark::Tms:0x000000000ebffac8 @label="", @real=1.703293478998603, @cstime=0.0, @cutime=0.0, @stime=0.043072999999999695, @utime=0.4282699999999995, @total=0.4713429999999992>

Results

Using real time:

43.06742242600012 seconds -> 3.9002713530007895 seconds
30.49937072099965 seconds -> 1.703293478998603 seconds

Acceptance Criteria

• Verify backend performance gains

Code Documentation Updates

• Add or update code comments at the top of the class, module, and/or component.

Storybook Story

For Frontend (Presentationa) Components

• Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
• Give it a title that reflects the component's location within the overall Caseflow hierarchy
• Write a separate story (within the same file) for each discrete variation of the component

[va-bot]

	1 Warning
⚠️	This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger

[codeclimate]

Code Climate has analyzed commit 6ad899e and detected 0 issues on this pull request.

View more on Code Climate.

[rubaiyat22]

Just noticed that the power of attorney detail in case details page has some extra line spaces which wasn't introduced by your PR but I'm wondering if you know this has always been like this.

Power of attorney detail compared to Veteran detail

|

[rubaiyat22]

nice! one less reducer

[rubaiyat22]

LGTM!!! left a comment about the power of attorney detail

[ferristseng]

Just noticed that the power of attorney detail in case details page has some extra line spaces which wasn't introduced by your PR but I'm wondering if you know this has always been like this.

Power of attorney detail compared to Veteran detail

|

I have not noticed this, but that is a good catch! I can see if I can tweak the styling it in this PR too

[ferristseng]

Resolved! Thank you for catching that: