Implements Backend of Case Movement for Blocked Cases #14957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 831ce2a and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
lomky
commented
Aug 13, 2020
Comment on lines
+54
to
+56
| # TODO: this _should_ not cancel after we finish | ||
| # https://github.com/department-of-veterans-affairs/caseflow/issues/14057 | ||
| # Distribution Blocking. Update this test to properly pass then! |
There was a problem hiding this comment.
TODO to be addressed in #14057
lomky
commented
Aug 13, 2020
|
|
||
| def self.label | ||
| COPY::CASE_MOVEMENT_TASK_LABEL | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def close_and_create_judge_task | ||
| def distribute_to_judge |
There was a problem hiding this comment.
renamed to better reflect the why of what's being done in both cases
lomky
commented
Aug 13, 2020
Comment on lines
+477
to
+482
| factory :extension_request_mail_task, class: ExtensionRequestMailTask do | ||
| parent { create(:root_task, appeal: appeal) } | ||
| assigned_to { MailTeam.singleton } | ||
| assigned_by { nil } | ||
| end | ||
|
|
There was a problem hiding this comment.
I needed a MailTask type that should actually block distribution
New appeal trait for realistic task tree appeal with blocked distribution due to mail New seeded appeals, 30 in Evidence Window and 30 with Blocking mail tasks
lomky
changed the base branch from
master
to
kat/14260_backend_cancel_block_tasks_main
|
replaced with stacked PR starting at #14964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14260
Description
Creates the backend logic for moving an appeal from the Case Storage to assigned to a judge, cancelling any Distribution blocking tasks along the way.
Acceptance Criteria
Testing Plan
Code Documentation Updates