Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appeals are able to determine if they are ready for Bva Dispatch to begin #15022

Merged
merged 14 commits into from
Aug 24, 2020
Merged

Appeals are able to determine if they are ready for Bva Dispatch to begin #15022

merged 14 commits into from
Aug 24, 2020

Conversation

lomky
Copy link
Contributor

@lomky lomky commented Aug 20, 2020 •
edited

Connects #14056

Description

Teaches Appeal (& LegacyAppeal) how to know if an appeal is ready for BVA Dispatch in preparation for allowing tasks to block bva dispatch

Acceptance Criteria

  • Tests pass
  • AMA Appeals can correct state if a BvaDispatchTask should be opened
  • Legacy Appeals should never be in a state to recieve a BvaDispatchTask

Testing Plan

  1. Review the test cases - double check any you are suspicious of? Run any additional tests? Am I missing any scenarios?

User Facing Changes

None

@lomky lomky self-assigned this Aug 20, 2020
@lomky lomky changed the title Kat/14056 blocks dispatch appeal ready for dispatch Appeals are able to determine if they are ready for Bva Dispatch to being Aug 20, 2020
@lomky lomky changed the title Appeals are able to determine if they are ready for Bva Dispatch to being Appeals are able to determine if they are ready for Bva Dispatch to begin Aug 20, 2020
lomky
lomky commented Aug 20, 2020
View reviewed changes
Gemfile.lock Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Aug 20, 2020 •
edited

Code Climate has analyzed commit dabbc0e and detected 0 issues on this pull request.

View more on Code Climate.

ajspotts
ajspotts approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@ajspotts ajspotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thorough testing for expected appeal scenarios 🙌

@lomky lomky added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Aug 21, 2020
@va-bot va-bot merged commit d89afd6 into master Aug 24, 2020
@va-bot va-bot deleted the kat/14056_blocks_dispatch_appeal_ready_for_dispatch branch August 24, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajspotts ajspotts ajspotts approved these changes

Assignees

@lomky lomky

Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lomky @ajspotts @va-bot