Add job to send virtual hearing reminder emails #15581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pellant/representative
…_emails_sent? check
Generated by 🚫 Danger |
|
Code Climate has analyzed commit 31ffa4c and detected 0 issues on this pull request. View more on Code Climate. |
ferristseng
requested review from
a team and
rubaiyat22
and removed request for
a team
ferristseng
commented
Nov 6, 2020
| @@ -7,10 +7,16 @@ class RecipientIsDeceasedVeteran < StandardError; end | |||
|
|
|||
| def initialize(virtual_hearing:, type:) | |||
| @virtual_hearing = virtual_hearing | |||
| @type = type | |||
| @type = type.to_s | |||
There was a problem hiding this comment.
Small refactor here so we don't have to call to_s when we're using type
| email_address: recipient.email, | ||
| external_message_id: external_id, | ||
| recipient_role: recipient_is_veteran ? "veteran" : recipient.title.downcase, | ||
| sent_by: virtual_hearing.updated_by | ||
| sent_by: type.ends_with?("reminder") ? User.system_user : virtual_hearing.updated_by |
There was a problem hiding this comment.
Tagging the system user as the person who sent the email, since technically no one is triggering the email to be sent
| class VirtualHearings::SendReminderEmailsJob < ApplicationJob | ||
| def perform | ||
| VirtualHearingRepository.maybe_ready_for_reminder_email.each do |virtual_hearing| | ||
| send_reminder_emails(virtual_hearing) |
There was a problem hiding this comment.
VirtualHearing::SendEmail seems pretty good at handling errors, so I don't know if we need to handle errors here? I could add a very broad begin/rescue
yoomlam
reviewed
Nov 9, 2020
db/migrate/20201104175215_add_reminder_email_flags_to_virtual_hearings.rb
Outdated
Show resolved
Hide resolved
yoomlam
reviewed
Nov 9, 2020
db/migrate/20201104175215_add_reminder_email_flags_to_virtual_hearings.rb
Outdated
Show resolved
Hide resolved
yoomlam
reviewed
Nov 9, 2020
rubaiyat22
approved these changes
Nov 12, 2020
| email_address: recipient.email, | ||
| external_message_id: external_id, | ||
| recipient_role: recipient_is_veteran ? "veteran" : recipient.title.downcase, | ||
| sent_by: virtual_hearing.updated_by | ||
| sent_by: type.ends_with?("reminder") ? User.system_user : virtual_hearing.updated_by |
|
|
||
| def days_from_hearing_day_to_last_sent_reminder | ||
| # Pick arbitrarily big value if the reminder has never been sent. | ||
| return 9999 if last_sent_reminder.nil? |
There was a problem hiding this comment.
what do you think about using Float::INFINITY here?
There was a problem hiding this comment.
I think that would work! Let me try that and see if the tests still pass
…nfirmed within the reminder period
ferristseng
added
the
Ready-to-Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15400
Resolves https://vajira.max.gov/browse/CASEFLOW-194
Description
VirtualHearings::SendReminderEmailsJobto send reminder emails on a schedule (TBD)VirtualHearingRepositorywith new method to find virtual hearings that might need reminder emailsVirtualHearings::ReminderServiceto determine when reminder emails need to be sentVirtualHearings::SendEmailto send reminder emailsappellant_reminder_sentandrepresentative_reminder_sentAcceptance Criteria
New templateCompleted in Create templates for virtual hearing reminder emails #15557Recording metrics on sends in Datadog, also alerting with failed sends as we do now for confirmationShould be handled already by logic inVirtualHearings::SendEmailDatabase Changes
Only for Schema Changes
Timestamps (created_at, updated_at) for new tablesCaseflow::Migration, especially when adding indexes (useadd_safe_index)migrate:rollbackworks as desired (changesupported functions)Query profiling performed (eyeball Rails log, check bullet and fasterer output)Appropriate indexes added (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)make docs(after runningmake migrate)Any non-obvious semantics or logic useful for interpreting database data is documented at Caseflow Data Model and Dictionary