Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certification metric to OIT Monthly Metrics Report Job #15768

Merged
merged 2 commits into from
Jan 12, 2021

Conversation

alisan16
Copy link
Contributor

Connects #12748

Description

Add the final OIT monthly metric (certification usage) to the MonthlyMetricsReportJob so that the metric is reported to Slack. With this, someone on the Caseflow team can simply copy and paste the Slack message from #appeals-job-alerts to send to OIT, rather than needing to login to the production console to run the certification metric manually every month.

Also refactored spec/services/metrics/certification_usage_spec.rb so the same test cases can be reused

Acceptance Criteria

  • Code compiles correctly
  • Rspec tests pass

Testing Plan

Updated test spec/jobs/monthly_metrics_report_job_spec.rb
Run locally and printed out rather than sending to Slack:

[1] pry(main)> MonthlyMetricsReportJob.perform_now
Monthly report 2020-12-01 to 2020-12-31
Percentage of all cases certified with Caseflow: 100.0
Appeals established within 7 days: 0 (100%)
Supplemental Claims within 7 days: 0 (NaN%)
Higher Level Reviews within 7 days: 0 (NaN%)
type,total,in_progress,cancelled,processed,established_within_seven_days,established_within_seven_days_percent,median,avg,max,min
supplemental_claims,0,0,0,0,0,NaN,00:00:00,00:00:00,00:00:00,00:00:00
higher_level_reviews,0,0,0,0,0,NaN,00:00:00,00:00:00,00:00:00,00:00:00
request_issues_updates,0,0,0,0,0,NaN,00:00:00,00:00:00,00:00:00,00:00:00
Performed MonthlyMetricsReportJob (Job ID: fcfef14e-d829-463b-b2b8-ed43939eb4d9) from Shoryuken(caseflow_development_low_priority) in 536.47ms

@alisan16 alisan16 added the Eng: Data Mark when data has been backfilled, or the issue has any data integrity concerns label Jan 11, 2021
@codeclimate
Copy link

codeclimate bot commented Jan 11, 2021

Code Climate has analyzed commit 830d68a and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@yoomlam yoomlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Automation for the win!

@alisan16 alisan16 added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Jan 12, 2021
@va-bot va-bot merged commit c9cef22 into master Jan 12, 2021
@va-bot va-bot deleted the alisan16/monthlymetrics branch January 12, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Eng: Data Mark when data has been backfilled, or the issue has any data integrity concerns Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants