Replicate prod bug: Case Movement user cannot reassign task #16206
Conversation
yoomlam
added
Stakeholder: BVA
Generated by 🚫 Danger |
|
Code Climate has analyzed commit 95fddf8 and detected 0 issues on this pull request. View more on Code Climate. |
| JudgeCaseReview => { | ||
| sanitize_fields: %w[comment], | ||
| retrieval: lambda do |records| | ||
| judge_task_ids = Task.where(type: JudgeTask.descendants.map(&:name), appeal: records[Appeal]).ids | ||
| JudgeCaseReview.where(task_id: judge_task_ids).order(:id) | ||
| end | ||
| }, | ||
| AttorneyCaseReview => { | ||
| sanitize_fields: %w[comment], | ||
| retrieval: lambda do |records| | ||
| atty_task_ids = Task.where(type: AttorneyTask.descendants.map(&:name), appeal: records[Appeal]).ids | ||
| AttorneyCaseReview.where(task_id: atty_task_ids).order(:id) | ||
| end | ||
| }, |
There was a problem hiding this comment.
Reordering so that these CaseReviews are exported after Tasks because they rely on tasks.
| @@ -276,7 +276,7 @@ def id_offset | |||
| # Start with important types that other records will reassociate with | |||
| def first_types_to_import | |||
| # HearingDay is needed by Hearing | |||
| @first_types_to_import ||= [Appeal, Organization, User, HearingDay] | |||
| @first_types_to_import ||= [Appeal, Organization, User, HearingDay, Task] | |||
There was a problem hiding this comment.
Ensure Tasks are one of the types imported before other records, i.e. CaseReviews, because CaseReviews rely on Tasks existing in the DB.
| elsif obj_hash[field_name].is_a?(String) | ||
| obj_hash[field_name] = (obj_hash[field_name].to_i + @id_offset).to_s |
There was a problem hiding this comment.
CaseReview records use strings for task_id to refer to legacy appeals, so we need to handle strings. This importer currently only supports AMA appeals so these strings can be converted to integers without error.
|
Hi Yoom, I tried to test this PR but I think I am missing a step. Could you please clarify? First, I ran my app locally and logged in as a user with Special Case Movement roles. Then, I navigated to an appeal that was at the quality review phase and reassigned the case to an attorney. I didn't see an error banner or an error message in dev console when I took these steps. Below, I included a screen recording of the process. TestYoomSCMPRNotInSpec.movIf it's helpful, here is the task tree of the appeal that I worked with locally.
Then, I had a facepalm moment when I realized that uncommenting the TestYoomSCMPRInTest.movCould you please clarify how I should test this PR and reproduce the "Error assigning tasks" error? Thanks! |
yoomlam
added
the
Ready-to-Merge
In response to an issue from Mike Sanford: Cannot Assign Task to Any Attorney #187.
Description
Add test for replicating a bug in production where a Case Movement user cannot reassign task during Quality Review.
This will help with fixing #16205.
Acceptance Criteria
Testing Plan
Add a
binding.pryand run the test in spec/fixes/investigate_scm_cant_reassign_spec.rb