Upgrade Ruby from 2.5.3 to 2.7.3 #16349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgantick
changed the title
bgantick
added
Eng: Backend Work Group
|
Code Climate has analyzed commit fa4161c and detected 0 issues on this pull request. View more on Code Climate. |
bgantick
changed the title
bgantick
changed the title
…ment-of-veterans-affairs/caseflow into bgantick/ruby-upgrade-2.7
n1zyy
approved these changes
Jul 26, 2021
| @@ -85,8 +85,6 @@ group :test, :development, :demo do | |||
| gem "brakeman" | |||
| gem "bullet" | |||
| gem "bundler-audit" | |||
| # Call 'byebug' anywhere in the code to stop execution and get a debugger console | |||
| gem "byebug", platforms: :ruby | |||
There was a problem hiding this comment.
Just for posterity, I asked about this in Slack and the answer is that pry-byebug gives us byebug, so this isn't actually removing the functionality.
| @@ -4,7 +4,7 @@ | |||
| factory :intake do | |||
| veteran_file_number { create(:veteran).file_number } | |||
| detail { create(:higher_level_review) } | |||
| type { detail.class.name << "Intake" } | |||
| type { detail.class.name + "Intake" } | |||
There was a problem hiding this comment.
Whoa, I wouldn't have guessed << was ever allowed for string concatenation. 👍
| check judge_task_one.id.to_s, allow_label_click: true | ||
| check judge_task_two.id.to_s, allow_label_click: true | ||
| page.find(:css, "input[name='#{judge_task_one.id}']", visible: false).execute_script("this.click()") | ||
| page.find(:css, "input[name='#{judge_task_two.id}']", visible: false).execute_script("this.click()") |
There was a problem hiding this comment.
It is weird to me that this is the only test that needed any updates. But I guess that's a good thing! :)
bgantick
added
the
Ready-to-Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades Caseflow's Ruby version from 2.5.3 to 2.7.3. Some additional gem updates for compatibility.
Acceptance Criteria
Testing Plan