RSpec to replicate duplicate JudgeAssignTasks problem #16382
Conversation
Generated by 🚫 Danger |
|
Code Climate has analyzed commit 3d5612b and detected 0 issues on this pull request. View more on Code Climate. |
|
Yoom, I looked at the task tree after activating the breakpoint on line 68, and I’m confused. I see one Should I examine the task tree at a different point in the test’s progress? Thanks! |
@eileen-nava Note the |
There was a problem hiding this comment.
@eileen-nava Note the
explainpage was loaded before any modifications were made to the appeal to show the imported appeal. If you reload theexplainpage in your browser, it shows the most recent task tree. Or you canappeal.reload.treeein the pry prompt.
Got it, thanks! 👍
| "middle_name": "P", | ||
| "name_suffix": null, | ||
| "closest_regional_office": null, | ||
| "ssn": "000765067", |
There was a problem hiding this comment.
In keeping with "Check that json file contains no PII," I want to confirm that none of the ssns in this file are actual social security numbers. (I don't think they are but, I am double-checking in the spirit of due diligence.)
There was a problem hiding this comment.
See https://secure.ssa.gov/poms.nsf/lnx/0110201035 for reference.
| Functions.grant!("System Admin", users: ["PETERSBVAM"]) # enable access to `export` endpoint | ||
| end | ||
|
|
||
| # Ticket: https://github.com/department-of-veterans-affairs/dsva-vacols/issues/174 |
There was a problem hiding this comment.
Is it standard to link to tickets in comments? Part of me wonders if this could bloat the codebase over time.
There was a problem hiding this comment.
Not sure what you mean by bloat. The URL should always work. I like to include links to cross-references. In this case, the ticket provide more context in understanding the purpose of the RSpec and there may be updates to that ticket that aren't captured in this RSpec.
Bumps https://github.com/department-of-veterans-affairs/dsva-vacols/issues/174
Description
Add RSpec to replicate duplicate JudgeAssignTasks problem.
PR #16072 should address the problem.
Acceptance Criteria
Testing Plan
Uncomment
binding.pryin the RSpec and examine the browser tabs and task tree.Check that json file contains no PII.