Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POA: Edit/Update Button #16607

Merged
merged 9 commits into from
Aug 10, 2021
Merged

POA: Edit/Update Button #16607

merged 9 commits into from
Aug 10, 2021

Conversation

Sjones352
Copy link
Contributor

Connects https://vajira.max.gov/browse/CASEFLOW-1034

Description

User Story: As a VLJ Support Team user, I want the ability to indicate I want to edit an Appellant's information, so that I may correct any mistakes made during intake.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to ...

User Facing Changes

Screen Shot 2021-08-10 at 9 34 02 AM

@va-bot
Copy link
Collaborator

va-bot commented Aug 10, 2021

1 Warning
⚠️ This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger

@codeclimate
Copy link

codeclimate bot commented Aug 10, 2021

Code Climate has analyzed commit 715e593 and detected 0 issues on this pull request.

View more on Code Climate.

@nweinmeister nweinmeister changed the title WIP| POA: Edit/Update Button POA: Edit/Update Button Aug 10, 2021
@@ -119,6 +119,10 @@ class WorkQueue::AppealSerializer
appeal.claimant.is_a?(OtherClaimant) ? appeal.claimant&.unrecognized_appellant&.id : nil
end

attribute :has_poa do |appeal|
appeal.claimant&.power_of_attorney
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the appeal fetches the power of attorney data after the appeal is already loaded, so adding this so that we atleast know if there's a POA before having to wait for the call, that way we can decide how to render the update/edit link without having to wait for the poa call to go through

@nweinmeister nweinmeister added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Aug 10, 2021
@va-bot va-bot merged commit 64f6e7e into master Aug 10, 2021
@va-bot va-bot deleted the sandra/1034-edit-update-button branch August 10, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants