Ignore vulnerability for a week #6113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
lowellrex
added
the
Ready-to-Merge
drewish
reviewed
Jul 5, 2018
| @@ -11,8 +11,12 @@ task :security_caseflow do | |||
| puts "running bundle-audit to check for insecure dependencies..." | |||
| exit!(1) unless ShellCommand.run("bundle-audit update") | |||
There was a problem hiding this comment.
you could fold this into the next command by using the bundle-audit check --update flag
lowellrex
removed
the
Ready-to-Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI builds are currently failing due to a vulnerability in a third-party package we use. This PR ignores this vulnerability for a week. After a week
bundle-auditwill fail again and we will be reminded to look to see if a patch for the gem has been released.Link to issue on the Thor gem's github: rails/thor#514
I don't think it makes sense to try to get rid of our dependency on this gem since so many gems we rely on use it: