-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS-Library: add missing tokens after audit of formation #1074
Conversation
eek. Is it worth making a follow-up ticket for this clean-up work now to have in our backlog? I'm not sure the timeline for when we could do that though. What do you think @micahchiang? EDIT: Follow-up ticket here: |
…t-of-veterans-affairs/component-library into 2294-add-tokens-to-css-library
…t-of-veterans-affairs/component-library into 2294-add-tokens-to-css-library
Chromatic
https://2294-add-tokens-to-css-library--65a6e2ed2314f7b8f98609d8.chromatic.com
Description
This PR adds USWDS color tokens that exist in Formation to css-library. It also adds the DSVA semantic tokens as requested by @humancompanion-usds. Adding the semantic tokens means that there are now duplicate tokens (different name, same color value), for example
hub.careers
andvads-color-hub-careers
. In addition, there still exist primitive color tokens which optimally would not be included.The issue with removing the primitive color tokens and duplicates in this PR is that they are in use in
vets-website
right now. So we can leave them incss-library
to make the switch-over easier or remove the duplicates now but realize that before deprecating Formation we would need to update those variables when referenced invets-website
.Closes 2294
QA Checklist
Screenshots
Acceptance criteria
Definition of done