Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-Library: add missing tokens after audit of formation #1074

Merged
merged 16 commits into from
Mar 13, 2024

Conversation

it-harrison
Copy link
Contributor

@it-harrison it-harrison commented Mar 1, 2024

Chromatic

https://2294-add-tokens-to-css-library--65a6e2ed2314f7b8f98609d8.chromatic.com


Description

This PR adds USWDS color tokens that exist in Formation to css-library. It also adds the DSVA semantic tokens as requested by @humancompanion-usds. Adding the semantic tokens means that there are now duplicate tokens (different name, same color value), for example hub.careers and vads-color-hub-careers. In addition, there still exist primitive color tokens which optimally would not be included.

The issue with removing the primitive color tokens and duplicates in this PR is that they are in use in vets-website right now. So we can leave them in css-library to make the switch-over easier or remove the duplicates now but realize that before deprecating Formation we would need to update those variables when referenced in vets-website.

Closes 2294

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@it-harrison it-harrison added the minor For a minor Semantic Version change label Mar 1, 2024
@it-harrison it-harrison requested a review from a team as a code owner March 1, 2024 18:34
@jamigibbs
Copy link
Contributor

jamigibbs commented Mar 1, 2024

The issue with removing the primitive color tokens and duplicates in this PR is that they are in use in vets-website right now. So we can leave them in css-library to make the switch-over easier or remove the duplicates now but realize that before deprecating Formation we would need to update those variables when referenced in vets-website.

eek. Is it worth making a follow-up ticket for this clean-up work now to have in our backlog? I'm not sure the timeline for when we could do that though. What do you think @micahchiang?

EDIT: Follow-up ticket here:

@it-harrison it-harrison merged commit a2ef007 into main Mar 13, 2024
8 checks passed
@it-harrison it-harrison deleted the 2294-add-tokens-to-css-library branch March 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For a minor Semantic Version change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit Formation color tokens for adding to the CSS Library
3 participants