va-select: Add aria-describedby-message for screen readers #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ataker
commented
Apr 2, 2024
|
|
||
| const errorID = uswds ? 'input-error-message': 'error-message'; |
There was a problem hiding this comment.
I don't see a reason to keep these error message IDs different. Should we update this to be the same across both versions? Or not worth the effort?
There was a problem hiding this comment.
I would say not worth the effort, we'll be removing the V1 versions of components in a couple months anyways.
Andrew565
approved these changes
Apr 2, 2024
|
|
||
| const errorID = uswds ? 'input-error-message': 'error-message'; |
There was a problem hiding this comment.
I would say not worth the effort, we'll be removing the V1 versions of components in a couple months anyways.
jamigibbs
reviewed
Apr 2, 2024
|
I'm unable to test this in the Chromatic link because the link is broken (branch name is too long. It should to be 37 characters or less). Has it been verified to work with a screenreader? |
|
Working with screen reader, added screenshot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://dst25-87-va-select-add-aria-describedby--65a6e2ed2314f7b8f98609d8.chromatic.com
Description
Adds
aria-describedbytova-selectfor screen readers.Closes va-select needs describedby property #2587
QA Checklist
Designer has signed off on changes (if applicable. If not applicable provide reason why)No design changesScreenshots
No visual changes
Screen reader text:
Acceptance criteria
Definition of done