Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va-icon: Updating va-icon icon sprite sheet with new icons #1117

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

Andrew565
Copy link
Contributor

@Andrew565 Andrew565 commented Apr 12, 2024

Chromatic

https://9999-update-va-icons--65a6e2ed2314f7b8f98609d8.chromatic.com


Description

Out-of-band update to the va-icon icon sprite sheet. Adds several new icons, renames a few icons.

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@Andrew565 Andrew565 added the patch Patch change in semantic versioning label Apr 12, 2024
@Andrew565 Andrew565 self-assigned this Apr 12, 2024
@Andrew565 Andrew565 requested a review from a team as a code owner April 12, 2024 15:24
Copy link

@danbrady danbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Andrew565 Andrew565 merged commit 7b6e886 into main Apr 12, 2024
10 checks passed
@Andrew565 Andrew565 deleted the 9999-update-va-icons branch April 12, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch change in semantic versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants