Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename medium-mobile breakpoint to tablet #1119

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Rename medium-mobile breakpoint to tablet #1119

merged 1 commit into from
Apr 12, 2024

Conversation

nickjg231
Copy link
Contributor

@nickjg231 nickjg231 commented Apr 12, 2024 •
edited by github-actions bot

Chromatic

https://2679-rename-scss-breakpoint--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

Closes department-of-veterans-affairs/vets-design-system-documentation#2679

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

N/A

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@nickjg231 nickjg231 self-assigned this Apr 12, 2024
@nickjg231 nickjg231 requested a review from a team as a code owner April 12, 2024 19:41
powellkerry
powellkerry approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@powellkerry powellkerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickjg231 nickjg231 merged commit 4d98c3b into main Apr 12, 2024
10 checks passed
@nickjg231 nickjg231 deleted the 2679-rename-scss-breakpoint branch April 12, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powellkerry powellkerry powellkerry approved these changes

Assignees

@nickjg231 nickjg231

Labels
css-library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename medium-mobile breakpoint to tablet
2 participants
@nickjg231 @powellkerry