Check for isTouched before opening search suggestions #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powellkerry
approved these changes
Apr 17, 2024
jamigibbs
reviewed
Apr 17, 2024
| @@ -439,7 +452,7 @@ export class VaSearchInput { | |||
| return ( | |||
| <Host onBlur={handleBlur}> | |||
| <form class={formClasses} role="search"> | |||
| <label class="usa-sr-only" htmlFor="search-field">{label}</label> | |||
| <label class="usa-sr-only kokokok" htmlFor="search-field">{label}</label> | |||
There was a problem hiding this comment.
Is "kokokok" just a leftover thing from testing?
| // only open the listbox after the search input has been touched | ||
| this.isListboxOpen = false; | ||
| return | ||
| } | ||
| this.isListboxOpen = true; |
There was a problem hiding this comment.
Just a minor thing here but would a ternary simplify this logic or would that make it less readable?
this.isTouched ? this.isListBoxOpen = true : this.isListboxOpen = false;
jamigibbs
approved these changes
Apr 18, 2024
Andrew565
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://dst2676-search-suggestions--65a6e2ed2314f7b8f98609d8.chromatic.com
Description
Closes Search Typeahead component does not close as expected when the component loads with a value prefilled #2676
Do not open search suggestions if the search hasn't been touched.. This would happen if the search was filled on load.
To test:
QA Checklist
Screenshots
Before
https://github.com/department-of-veterans-affairs/component-library/assets/1413938/672b384c-5431-4d95-ab66-87219b639ab2
After
https://github.com/department-of-veterans-affairs/component-library/assets/1413938/851ea977-14c2-4277-86e3-1560424a70d3
Acceptance criteria
Definition of done