Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va-link: add reverse color #1141

Merged
merged 3 commits into from
May 2, 2024
Merged

va-link: add reverse color #1141

merged 3 commits into from
May 2, 2024

Conversation

Andrew565
Copy link
Contributor

@Andrew565 Andrew565 commented May 1, 2024

Chromatic

https://2602-reverse-va-link-color--65a6e2ed2314f7b8f98609d8.chromatic.com


Description

Closes #2602

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Screenshot 2024-05-01 at 2 13 33 PM
(Active link was hovered-over to demo that state)

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@Andrew565 Andrew565 added the minor For a minor Semantic Version change label May 1, 2024
@Andrew565 Andrew565 self-assigned this May 1, 2024
@Andrew565 Andrew565 requested a review from a team as a code owner May 1, 2024 18:18
Copy link
Contributor

@powellkerry powellkerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andrew565 Andrew565 requested a review from danbrady May 1, 2024 21:16
Copy link
Contributor

@it-harrison it-harrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Andrew565 Andrew565 merged commit 4fdaa5e into main May 2, 2024
9 checks passed
@Andrew565 Andrew565 deleted the 2602-reverse-va-link-color branch May 2, 2024 18:13
@jamigibbs jamigibbs changed the title 2602 - Reverse va-link color va-link: add reverse color May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For a minor Semantic Version change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow <va-link> to be a white link instead of default blue
4 participants