Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va-accordion: unhide content in print media #1146

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

Mottie
Copy link
Contributor

@Mottie Mottie commented May 14, 2024

Chromatic

https://2206-accordion-print--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

See #2206

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Default default accordion with print window showing all content
Icon headers accordion icon headers with print window showing all content
Accordions with subheaders accordions with subheaders with print window showing all content
Many accordions many accordions with print window showing all content

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@Mottie Mottie added the minor For a minor Semantic Version change label May 14, 2024
@Mottie Mottie self-assigned this May 14, 2024
@Mottie Mottie requested a review from a team as a code owner May 14, 2024 20:08
@jamigibbs jamigibbs added patch Patch change in semantic versioning and removed minor For a minor Semantic Version change labels May 14, 2024
@@ -32,3 +32,9 @@ button.va-accordion__button {
font-weight: bold;
float: right;
}

@media print {
Copy link
Contributor

@jamigibbs jamigibbs May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mottie! I have just one small request; is it possible to move this and the other new CSS block above the line that says this in the stylesheet? Or is there a specificity issue?

/** Original Component Style **/

Everything below that comment signals that it be considered for removal when we fully deprecate the v1 version and adding it above that comment will make it much clearer that we need to keep it with the USWDS version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@Mottie Mottie merged commit 7b0f51e into main May 15, 2024
11 checks passed
@Mottie Mottie deleted the 2206-accordion-print branch May 15, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch change in semantic versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants