update to new types lib #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Dec 18, 2020
| @@ -23,7 +23,7 @@ import EditPhoneNumberScreen from './screens/ProfileScreen/PersonalInformationSc | |||
| import WebviewScreen from './screens/WebviewScreen' | |||
| import configureStore, { AuthState, LOGIN_PROMPT_TYPE, StoreState, handleTokenCallbackUrl, initializeAuth } from 'store' | |||
| import i18n from 'utils/i18n' | |||
| import styled, { ThemeProvider } from 'styled-components/native' | |||
| import styled, { ThemeProvider } from 'styled-components' | |||
There was a problem hiding this comment.
we import styled in a few more files, those imports should be updated as well to styled-components instead of styled-components/native
|
closing, current form of styled component creation is deprecated. needs a story |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updates types file for Styled components. This was causing lint failures in a previous update of other libraries.
GitHub issue for the library is here DefinitelyTyped/DefinitelyTyped#49914
This updates the types to separate libraries for react and react native and should allow other libs to be updated
Reviewers
DF:
@jmarchi
@keli13
@komaly15